Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve access to byron addresses #2636

Merged
merged 3 commits into from Jan 31, 2022
Merged

Improve access to byron addresses #2636

merged 3 commits into from Jan 31, 2022

Conversation

lehins
Copy link
Contributor

@lehins lehins commented Jan 27, 2022 •
edited

Few other improvements that expand on the same idea from #2632

Also fixes #1788

There some places I was able to find that either:

  • deserialize Byron addresses, but then ignore the result in the end.
  • care only about Byron addresses, but result in deserialization of Shelley addresses as well, which get discarded.

@lehins
Implement efficient way of getting to Byron Address from TxOut
e007368
@lehins
Reduce duplication and optimize:
52609b7 
* Same logic for Shelley, ShelleyMA and Alonzo is now in new
  `filterOutputsAttrsTooBig`, which has improved performance
* Also optimize `vKeyLocked`
@lehins
Improve performance of translating an address in TxInfo
b73bd4c
@lehins lehins force-pushed the lehins/improve-access-to-byron-addresses branch from 540a566 to b73bd4c Compare January 27, 2022 02:06
JaredCorduan
JaredCorduan approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed in a call, looks good to me

@lehins lehins merged commit 0d00d08 into master Jan 31, 2022
@iohk-bors iohk-bors bot deleted the lehins/improve-access-to-byron-addresses branch January 31, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredCorduan JaredCorduan JaredCorduan approved these changes

@nc6 nc6 Awaiting requested review from nc6

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid repeated viewCompactTxOut in the Utxo rule
2 participants
@lehins @JaredCorduan