Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Babbage serialization tests #2666

Merged
merged 2 commits into from Feb 24, 2022
Merged

Babbage serialization tests #2666

merged 2 commits into from Feb 24, 2022

Conversation

goolord
Copy link
Contributor

@goolord goolord commented Feb 23, 2022

No description provided.

import Test.Tasty.QuickCheck
import Text.Show.Pretty (ppShow)

trippingF ::
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be nice to have a place to put common testing code like this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree! Let's make this a talking point next time the team meets. cardano-ledger-test is nice for things that live "at the end of all eras", but we don't have a good place for testing support that lives "before all eras".

@goolord goolord force-pushed the zc/babbage-ser-tests branch 5 times, most recently from f864405 to b0f2ca8 Compare February 23, 2022 20:51
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed through a PR overall looks pretty good. I left few comments. I'll do a proper review once the PR is finished

Sorry I commented at a wrong PR. I was reviewing another one

Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really great, thanks! I made some comments about trying to re-use generators from Alonzo, but besides that I think this is great.

Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks @goolord !

@JaredCorduan JaredCorduan merged commit 44ddabc into master Feb 24, 2022
@iohk-bors iohk-bors bot deleted the zc/babbage-ser-tests branch February 24, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants