babbage script well-formedness check #2717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goolord
commented
Apr 1, 2022
| (txscripts utxo tx) -- txscripts = babbageTxScripts which includes reference scripts. | ||
| in failureUnless | ||
| (Map.null failedScripts) | ||
| (Shelley.ScriptWitnessNotValidatingUTXOW $ Map.keysSet failedScripts) |
There was a problem hiding this comment.
is this still an accurate name? this test also validates reference scripts
There was a problem hiding this comment.
good point. I also think that the Not is weird in that name.
goolord
force-pushed
the
zc/isWellFormed-check
branch
3 times, most recently
from
c510243
to
ec59ec5
Compare
goolord
force-pushed
the
zc/isWellFormed-check
branch
from
ec59ec5
to
f7ed964
Compare
|
should be all premo now 🙆 |
goolord
force-pushed
the
zc/isWellFormed-check
branch
from
f7ed964
to
ecee3a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i think this small check is all that's necessary
txscriptsset for babbagetxscriptssetresolves #2713