fix babbage min utxo calculation #2766
Conversation
We should be forced to think about each protocol parameter in each error to ensure we do not falsely assume a field in a given era is being set but is actually being ignored.
We make a unit test that we expect to fail, namely we create a transaction output that is large due an inline datum which should trigger the OutputTooSmallUTxO failure.
It should not be based on the serialized size of the value, but rather the serialized size of the entire transaction output.
The OutputTooSmallUTxO in Alonzo does not tell the user what the minimum size actually was for the given transaction output, which is very helpful information. We include this information in the babbage era predicate failure.
| | -- | list of supplied transaction outputs that are too small, | ||
| -- together with the minimum value for the given output. | ||
| BabbageOutputTooSmallUTxO | ||
| ![(Core.TxOut era, Integer)] | ||
|
|
There was a problem hiding this comment.
Could we please include the Hash of the TxBody here as well. It is often impossible to determine which Tx an predicate failure arise from. This would be very useful in may paces, but at least we have the opportunity to do it here.
There was a problem hiding this comment.
that's a bigger refactor than I was looking to do in this PR... at least if we want any kind of consistency... maybe we can make that a stretch goal in a follow up PR? this is helpful for us when testing, but is probably not actually helpful for most users, who get the predicate failure after locally submitting a single Tx.
| CollateralPercentage 1, | ||
| AdaPerUTxOWord (Coin 5) |
There was a problem hiding this comment.
Is it a percentage,or is it a rational (or float) between 0 and 1?
There was a problem hiding this comment.
it is a number of lovelace
Fix the bug in the Babbage minimum utxo calculation. closes #2765
This commit can be review commit by commit:
AdaPerUTxOWordfield.In addition to the unit test added in this PR, we will soon change the value of
AdaPerUTxOWordin the property tests to something non-zero.