Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Babbage era evaluateMinLovelaceOutput function #2814

Merged
merged 1 commit into from May 23, 2022
Merged

Fix Babbage era evaluateMinLovelaceOutput function #2814

merged 1 commit into from May 23, 2022

Conversation

JaredCorduan
Copy link
Contributor

The babbage era evaluateMinLovelaceOutput should use the serialized bytes, not utxoEntrySize.

closes #2812

@JaredCorduan JaredCorduan requested a review from lehins May 23, 2022 19:02
Fix Babbage era evaluateMinLovelaceOutput function
d49c223 
It should use the serialized bytes, not utxoEntrySize
@JaredCorduan JaredCorduan force-pushed the jc/fix-babbage-evaluateMinLovelaceOutput branch from c5db43f to d49c223 Compare May 23, 2022 20:02
lehins
lehins approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaredCorduan JaredCorduan merged commit c99616a into master May 23, 2022
@iohk-bors iohk-bors bot deleted the jc/fix-babbage-evaluateMinLovelaceOutput branch May 23, 2022 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehins lehins lehins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Babbage era evaluateMinLovelaceOutput class method is wrong
2 participants
@JaredCorduan @lehins