Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cardano-cli reports protocol version 8 in Conway era #3491

Closed
johnalotoski opened this issue Jun 20, 2023 · 1 comment · Fixed by IntersectMBO/ouroboros-consensus#366
Closed
Assignees
Labels
conway SanchoNet Minimal working version of Governance
Projects

Comments

@johnalotoski
Copy link

When in Babbage protocol version 8 and doing a proposal update to Conway protocol version 9, cardano-cli query tip will show the expected switch from Babbage to Conway era at the next epoch transition.

Now, while in Conway era, cardano-cli querying protocol-parameters still shows protocol version as 8.

# While in Conway era -- check query tip output:
> cardano-cli query tip
{
    "block": 24516,
    "epoch": 5,
    "era": "Conway",
    "hash": "86a514fce42ad660ed587b0afe4a731bd01090d82de2225c5a9e15517a8ca068",
    "slot": 492091,
    "slotInEpoch": 60091,
    "slotsToEpochEnd": 26309,
    "syncProgress": "100.00"
}

# Then query protocol parameters, however still show version 8:
> cardano-cli query protocol-parameters | jq .protocolVersion
{
  "major": 8,
  "minor": 0
}

# The proposal update logged in node does show pvMajor Version 9 for the hard fork:
Event: LedgerUpdate (HardForkUpdateInEra S (S (S (S (S (Z (WrapLedgerUpdate {unwrapLedgerUpdate = ShelleyUpdatedProtocolUpdates [ProtocolUpdate {protocolUpdateProposal = UpdateProposal {proposalParams = PParamsUpdate (BabbagePParams {bppMinFeeA = SNothing, bppMinFeeB = SNothing, bppMaxBBSize = SNothing, bppMaxTxSize = SNothing, bppMaxBHSize = SNothing, bppKeyDeposit = SNothing, bppPoolDeposit = SNothing, bppEMax = SNothing, bppNOpt = SNothing, bppA0 = SNothing, bppRho = SNothing, bppTau = SNothing, bppProtocolVersion = SJust (ProtVer {pvMajor = Version 9, pvMinor = 0}), bppMinPoolCost = SNothing, bppCoinsPerUTxOByte = SNothing, bppCostModels = SNothing, bppPrices = SNothing, bppMaxTxExUnits = SNothing, bppMaxBlockExUnits = SNothing, bppMaxValSize = SNothing, bppCollateralPercentage = SNothing, bppMaxCollateralInputs = SNothing}), proposalVersion = Just (ProtVer {pvMajor = Version 9, pvMinor = 0}), proposalEpoch = EpochNo 4}, protocolUpdateState = UpdateState {proposalVotes = [KeyHash "c1ad22cabb342cbb83ce3859708232f4945ccb669e9b5f932cffc0ed",KeyHash "c264bca994a3a5deee5a1d9b92a3d7e9d6cbdb81f2f6989bb7f7b437",KeyHash "d4bf7eb45b72dffa5ac33d5c902fe409e4e611f2e9a52fb0d09784c3"], proposalReachedQuorum = True}}]})))))))
@lehins lehins added this to To do in Conway via automation Jul 18, 2023
@lehins lehins added the SanchoNet Minimal working version of Governance label Jul 18, 2023
@teodanciu teodanciu moved this from To do to In progress in Conway Aug 30, 2023
@teodanciu teodanciu self-assigned this Aug 30, 2023
@teodanciu
Copy link
Contributor

The current hypothesis is that the protocol update doesn't actually happen when transitioning to Conway, because Translation is losing the update proposals from the LedgerState. The explanation and plan is in this consensus ticket

@lehins lehins moved this from In progress to To do in Conway Sep 12, 2023
github-merge-queue bot pushed a commit to IntersectMBO/ouroboros-consensus that referenced this issue Sep 25, 2023
Closes IntersectMBO/cardano-ledger#3491 in
an ad-hoc but minimal fashion.

Primary motivation is to fix this bug on Sanchonet without having to
wait for the full HFC refactoring (see #345) that we will probably end
up with.
Conway automation moved this from To do to Done Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conway SanchoNet Minimal working version of Governance
Projects
Status: Done
Conway
  
Done
4 participants