Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ppSoftForkRule instead of upAdptThd #377

Closed
dnadales opened this issue Apr 5, 2019 · 0 comments
Closed

Use ppSoftForkRule instead of upAdptThd #377

dnadales opened this issue Apr 5, 2019 · 0 comments
Labels
byron 📜 formal-spec

Comments

@dnadales
Copy link
Member

dnadales commented Apr 5, 2019

In the spec we make use of a non-existing protocol parameter upAdptThd. In the implementation we use ppSoftForkRule in combination with the number of genesis keys.

We should update the spec so that it matches what is actually happening in the implementation.

For background see this comment
This was referenced Apr 5, 2019
Merged
Merged
nc6 pushed a commit that referenced this issue May 19, 2020
@AskAlexSharov
#377 - Rename ProtocolParameterUpdate to ProtocolParametersUpdate
69133dc
nc6 pushed a commit that referenced this issue May 19, 2020
@iohk-bors @AskAlexSharov
Merge #386
83dd5f7 
386: #377 - Rename ProtocolParameterUpdate to ProtocolParametersUpdate r=ruhatch a=AskAlexSharov

Ticket: #377

- renamed ProtocolParameterUpdate to ProtocolParametersUpdate
- renamed golden file
- renamed related functions 
- updated comments

Co-authored-by: alex.sharov <askalexsharov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
byron 📜 formal-spec
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dnadales