Fix costmodel creation in Alonzo Genesis #3101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodanciu
force-pushed
the
td/fix-alonzo-genesis
branch
2 times, most recently
from
83038f9
to
295e71b
Compare
JaredCorduan
approved these changes
Oct 25, 2022
There was a problem hiding this comment.
This looks great to me, thank you @teodanciu !
@Jimbo4350 - you should be aware that the CLI is going to need to use legacyParseCostModels for parsing the original alonozo genesis file.
teodanciu
force-pushed
the
td/fix-alonzo-genesis
branch
3 times, most recently
from
3a25ab9
to
670f5b5
Compare
instead of the plutus `ParamName` enum, since the latter returns slightly different names for 6 parameters: "blake2b_256-cpu-arguments-intercept", "blake2b_256-cpu-arguments-slope", "blake2b_256-memory-arguments", "verifyEd25519Signature-cpu-arguments-intercept", "verifyEd25519Signature-cpu-arguments-slope", "verifyEd25519Signature-memory-arguments" Instead of the names expected by the alonzo genesis file: "blake2b-cpu-arguments-intercept", "blake2b-cpu-arguments-slope", "blake2b-memory-arguments", "verifySignature-cpu-arguments-intercept", "verifySignature-cpu-arguments-slope", "verifySignature-memory-arguments" Also, replace the `FromJSON` instance with a function, to make it clear that it's a legacy implementation. respectively.
and the sorting of cost model parameters
which is needed for the future, non-legacy parsing of genesis and also for current testing.
teodanciu
force-pushed
the
td/fix-alonzo-genesis
branch
from
670f5b5
to
a3c3451
Compare
|
Hello @Jimbo4350 - would you mind taking a look at this before we're merging it? Just to make sure it will work with your plans for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.