Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't run unnecessary gh actions #3320

Merged
merged 2 commits into from Mar 13, 2023
Merged

Don't run unnecessary gh actions #3320

merged 2 commits into from Mar 13, 2023

Conversation

teodanciu
Copy link
Contributor

@teodanciu teodanciu commented Mar 6, 2023 •
edited

Description

Reduces the number of github actions run by cancelling workflows when a new one for the same PR is starting

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@teodanciu teodanciu marked this pull request as ready for review March 7, 2023 12:28
@teodanciu teodanciu requested a review from a team as a code owner March 7, 2023 12:28
lehins
lehins approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fix to a comment, otherwise looks great.

@teodanciu teodanciu enabled auto-merge (rebase) March 13, 2023 12:11
@teodanciu teodanciu merged commit 3e1762f into master Mar 13, 2023
6 checks passed
@iohk-bors iohk-bors bot deleted the td/reduce-gh-actions-runs branch March 13, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JaredCorduan JaredCorduan JaredCorduan left review comments

@lehins lehins lehins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@teodanciu @JaredCorduan @lehins