Add PParams for Conway #3498
Merged
Add PParams for Conway #3498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aniketd
force-pushed
the
aniketd/conway-certs-3442
branch
from
29c7fda
to
d76c67c
Compare
teodanciu
reviewed
Jun 28, 2023
teodanciu
reviewed
Jun 28, 2023
teodanciu
reviewed
Jun 28, 2023
lehins
requested changes
Jun 28, 2023
There was a problem hiding this comment.
This looks great. Voting thresholds need some work still. There is a related spec PR was opened earlier today: IntersectMBO/formal-ledger-specifications#134
Soupstraw
force-pushed
the
aniketd/conway-certs-3442
branch
5 times, most recently
from
193fb95
to
d7b462f
Compare
|
LGTM, good job @aniketd! |
Soupstraw
approved these changes
Jul 7, 2023
lehins
requested changes
Jul 7, 2023
Soupstraw
force-pushed
the
aniketd/conway-certs-3442
branch
7 times, most recently
from
bc895b7
to
8dee5f0
Compare
Soupstraw
force-pushed
the
aniketd/conway-certs-3442
branch
from
8dee5f0
to
2dd1826
Compare
teodanciu
approved these changes
Jul 19, 2023
teodanciu
reviewed
Jul 19, 2023
teodanciu
reviewed
Jul 19, 2023
There was a problem hiding this comment.
Before merging, check that the version of cardano-ledger-conway is more than 1.6.1.1 (either by changing it in this PR or by rebasing, whichever is needed at the time of merging)
Actually nevermind, 1.6.1.1 is not on chap, my mistake (unless... someone bumps to 1.6.1.1 and releases to chap before you merge this 😆 )
Soupstraw
force-pushed
the
aniketd/conway-certs-3442
branch
from
d4770d2
to
7b9bb85
Compare
Soupstraw
force-pushed
the
aniketd/conway-certs-3442
branch
from
d0be5d9
to
7b20016
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
PParamsforConwayFixes #3146
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)