Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conway Genesis PParams #3499

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Conway Genesis PParams #3499

merged 1 commit into from
Jul 21, 2023

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Jun 28, 2023 •
edited by lehins

Description

Add PParams to ConwayGenesis for Translation.

Fixes #2948 and #3160

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@aniketd aniketd requested review from lehins and Soupstraw June 28, 2023 14:57
@Soupstraw Soupstraw force-pushed the aniketd/conway-certs-3442 branch 5 times, most recently from 193fb95 to d7b462f Compare July 7, 2023 10:26
@Soupstraw Soupstraw force-pushed the aniketd/conway-genesis-pparams branch from c636523 to c610a9a Compare July 7, 2023 11:50
lehins
lehins requested changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall direction is good. Needs:

  • a rebase on the PParams implementation
  • inside JSON hiding the fact that Genesis contains UpgradePParams
  • Creating a pattern synonym that hides the fact that Genesis contains UpgradePParams. See AlonzoGenesis

eras/conway/impl/src/Cardano/Ledger/Conway/Genesis.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Genesis.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/PParams.hs Outdated Show resolved Hide resolved
@Soupstraw Soupstraw force-pushed the aniketd/conway-genesis-pparams branch 7 times, most recently from f4dce00 to 1adbfce Compare July 18, 2023 13:13
@Soupstraw Soupstraw force-pushed the aniketd/conway-genesis-pparams branch 2 times, most recently from 91199f1 to 69b02e8 Compare July 18, 2023 13:20
@Soupstraw Soupstraw requested a review from lehins July 18, 2023 13:21
@Soupstraw Soupstraw force-pushed the aniketd/conway-genesis-pparams branch from 69b02e8 to b656698 Compare July 18, 2023 13:27
@Soupstraw Soupstraw force-pushed the aniketd/conway-certs-3442 branch 5 times, most recently from 8afba03 to bc895b7 Compare July 18, 2023 14:52
@lehins lehins mentioned this pull request Jul 18, 2023
Closed
4 tasks
@Soupstraw Soupstraw force-pushed the aniketd/conway-certs-3442 branch 2 times, most recently from 8dee5f0 to 2dd1826 Compare July 19, 2023 09:42
@Soupstraw Soupstraw force-pushed the aniketd/conway-genesis-pparams branch 2 times, most recently from 6b81843 to 19b04de Compare July 20, 2023 13:06
@iohk-bors iohk-bors bot deleted the branch master July 20, 2023 14:36
@iohk-bors iohk-bors bot closed this Jul 20, 2023
@lehins lehins reopened this Jul 21, 2023
@lehins lehins changed the base branch from aniketd/conway-certs-3442 to master July 21, 2023 09:01
@aniketd aniketd force-pushed the aniketd/conway-genesis-pparams branch 2 times, most recently from 6b06781 to 2d0d8d2 Compare July 21, 2023 10:57
@aniketd aniketd force-pushed the aniketd/conway-genesis-pparams branch from 2d0d8d2 to a05ba61 Compare July 21, 2023 11:00
teodanciu
teodanciu approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the commit Add PParams for Conway is not accurate I think (I suspect due to rebasing and stuff), so maybe we could change that to mention ConwayGenesis ?

@aniketd
Copy link
Contributor Author

aniketd commented Jul 21, 2023

@teodanciu I missed that! 💯 Fixing!

@aniketd
Add PParams to ConwayGenesis
5896309 
Also, remove TranslateEra instance for ProposedPPUpdates
@aniketd aniketd force-pushed the aniketd/conway-genesis-pparams branch from a05ba61 to 5896309 Compare July 21, 2023 11:13
lehins
lehins approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!

@aniketd aniketd enabled auto-merge July 21, 2023 11:17
@aniketd aniketd merged commit f67b518 into master Jul 21, 2023
11 of 12 checks passed
@iohk-bors iohk-bors bot deleted the aniketd/conway-genesis-pparams branch July 21, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teodanciu teodanciu teodanciu approved these changes

@lehins lehins lehins approved these changes

@Soupstraw Soupstraw Awaiting requested review from Soupstraw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conway genesis
4 participants
@aniketd @teodanciu @lehins @Soupstraw