Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Procedures #3521

Merged
merged 1 commit into from
Jul 6, 2023
Merged

Separate Procedures #3521

merged 1 commit into from
Jul 6, 2023

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Jul 4, 2023

Description

This PR replaces the signal of the TALLY rule for a new GovernanceProcedures datatype, which stores votes and proposals separately. This new type resides in the new Cardano.Ledger.Conway.Governance.Procedures file, which is re-exported by Cardano.Ledger.Conway.Governance.

resolve #3513

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Soupstraw Soupstraw marked this pull request as draft July 4, 2023 11:41
@Soupstraw Soupstraw changed the title WIP - Separate Procedures Separate Procedures Jul 4, 2023
@Soupstraw Soupstraw force-pushed the jj/separate-proposals branch 4 times, most recently from 664c401 to f51a367 Compare July 4, 2023 14:25
@Soupstraw Soupstraw marked this pull request as ready for review July 4, 2023 14:27
@Soupstraw Soupstraw requested review from lehins and aniketd July 4, 2023 14:58
Copy link
Contributor

@aniketd aniketd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🙌

Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is perfect. Due to a new release a few more things are needed:

  • Version bump
  • Update to deps and version bump in cardano-ledger-conway-test

eras/conway/impl/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@Soupstraw Soupstraw merged commit 143e7bb into master Jul 6, 2023
10 of 11 checks passed
@iohk-bors iohk-bors bot deleted the jj/separate-proposals branch July 6, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop combining VotingProcedure and ProposalProcedure
3 participants