-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate Procedures #3521
Separate Procedures #3521
Conversation
664c401
to
f51a367
Compare
f51a367
to
5d8655a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is perfect. Due to a new release a few more things are needed:
- Version bump
- Update to deps and version bump in
cardano-ledger-conway-test
eras/conway/impl/src/Cardano/Ledger/Conway/Governance/Procedures.hs
Outdated
Show resolved
Hide resolved
5d8655a
to
189e6ed
Compare
189e6ed
to
aa38e24
Compare
aa38e24
to
6c9b0fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
Description
This PR replaces the signal of the TALLY rule for a new
GovernanceProcedures
datatype, which stores votes and proposals separately. This new type resides in the newCardano.Ledger.Conway.Governance.Procedures
file, which is re-exported byCardano.Ledger.Conway.Governance
.resolve #3513
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)