Plutus type improvement #3531
Merged
Plutus type improvement #3531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
force-pushed
the
lehins/plutus-type-improvement
branch
from
76c5845
to
4d66567
Compare
teodanciu
reviewed
Jul 18, 2023
teodanciu
reviewed
Jul 18, 2023
teodanciu
approved these changes
Jul 18, 2023
* Change type of `Plutus` to use `BinaryPlutus` instead of `ShortByteString` * Deprecate `runPLCScript` in favor of `runPlutusScript` * Addition of `PlutusWithContext` * Deprecation of `collectTwoPhaseScriptInputs` in favor of `collectPlutusScriptsWithContext` * Deprecation of `evalScripts` in favor of `evalPlutusScripts` * Deprecation of `runPLCScript` in favor of `runPlutusScript` * Deprecation of `explainPlutusFailure` in favor of `explainPlutusEvaluationError` * Move `BinaryPlutus` into `cardano-ledger-core` package in `Cardano.Ledger.Language` module * Change `PlutusScript` constructor of the `AlonzoScript` type. It now accepts the new `Plutus` type instead of a `Language` and `ShortByteString` * Rename `pdSBS` field to `pdPlutusScript` in the `PlutusDebugLang` data type * Added `withSLanguage` * Move `BinaryPlutus` from `cardano-ledger-alonzo` and changed its `Show` instance to display as base64 encoding. * Added `Plutus` * Changed `Phase2Script` constructor of the `PhaseScript` type. It now accepts new `Plutus` type instead of `Language` and `ShortByteString`
lehins
force-pushed
the
lehins/plutus-type-improvement
branch
from
4d66567
to
7f148c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does not change any Plutus semantics for all eras except Conway. It brings some type safety to Plutus ledger types and cleans up the code a bit.
For Conway it prepares the code to make it clearer a bit, but only after we are in Conway (see the added comment in the code)
Major parts of this PR are:
Plutusdata type and changingPlutusScript !Language !ShortByteStringtoPlutusScript !PlutusPlutusWithContextto avoid gross usage of four tuples and reduce number of arguments to a few functionsMost of the changes where done with deprecation in mind.
See changelogs or individual commits for more info
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)