Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PParams into the GovState #3550

Closed
lehins opened this issue Jul 18, 2023 · 0 comments · Fixed by #3577
Closed

Move PParams into the GovState #3550

lehins opened this issue Jul 18, 2023 · 0 comments · Fixed by #3577
Assignees
Labels
conway SanchoNet Minimal working version of Governance
Projects

Comments

@lehins
Copy link
Contributor

lehins commented Jul 18, 2023

In Conway PParams have moved into the EnactState, which is part of the governance state, because it is the governance process that will be responsible for updating them. It would be very undesired to keep two sources of truth: one in EpochState and another in EnactState. In order to make it uniform across eras we can move the esPp into GovernanceState type family and provide a lens ppGovStateL that provides access to the current PParams.

@lehins lehins added the conway label Jul 18, 2023
@lehins lehins added this to To do in Conway via automation Jul 18, 2023
@lehins lehins added the SanchoNet Minimal working version of Governance label Jul 18, 2023
@Soupstraw Soupstraw self-assigned this Jul 25, 2023
@lehins lehins moved this from To do to In progress in Conway Jul 25, 2023
@lehins lehins moved this from In progress to In review in Conway Aug 7, 2023
Conway automation moved this from In review to Done Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conway SanchoNet Minimal working version of Governance
Projects
Status: Done
Conway
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants