Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Anchor required in ProposalProcedure #3554

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Make Anchor required in ProposalProcedure #3554

merged 2 commits into from
Jul 20, 2023

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Jul 20, 2023 •
edited

Description

Resolves #3535

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

Soupstraw
Soupstraw approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@Soupstraw Soupstraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aniketd aniketd enabled auto-merge July 20, 2023 12:16
@aniketd aniketd merged commit a86a2c6 into master Jul 20, 2023
10 of 14 checks passed
@iohk-bors iohk-bors bot deleted the aniketd/pprocanchor-required branch July 20, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Soupstraw Soupstraw Soupstraw approved these changes

@teodanciu teodanciu Awaiting requested review from teodanciu

@lehins lehins Awaiting requested review from lehins

@TimSheard TimSheard Awaiting requested review from TimSheard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Anchor required for ProposalProcedure
2 participants
@aniketd @Soupstraw