Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NewCommittee action to use Credential and add more info #3557

Merged
merged 1 commit into from
Jul 30, 2023
Merged

Update NewCommittee action to use Credential and add more info #3557

merged 1 commit into from
Jul 30, 2023

Conversation

teodanciu
Copy link
Contributor

@teodanciu teodanciu commented Jul 20, 2023 •
edited by lehins

namely: old committee and the expiration epoch for each new member. Also update EnactState to reflect these changes

Closes #3543

Draft because I haven't figured out how to update scriptsNeeded for this

Description

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@teodanciu teodanciu marked this pull request as ready for review July 21, 2023 14:56
lehins
lehins requested changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have said this in the ticket, but it was only after I looked at the code I realized that it would be good to add a whole new type for the Committee

eras/conway/impl/src/Cardano/Ledger/Conway/Governance/Procedures.hs Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Governance.hs Outdated Show resolved Hide resolved
aniketd
aniketd reviewed Jul 26, 2023
View reviewed changes
Copy link
Contributor

@aniketd aniketd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI, there is WIP to make the CommitteeColdKey from a KeyHash to a Credential #3564

@lehins lehins force-pushed the td/newcommittee-improvements branch from eb2a2bf to 4863bdf Compare July 28, 2023 15:55
@lehins lehins requested a review from aniketd July 28, 2023 15:55
lehins
lehins approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

aniketd
aniketd approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@aniketd aniketd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a single doubt (question), but otherwise looks good! 🙌

eras/conway/impl/src/Cardano/Ledger/Conway/Governance/Procedures.hs Outdated Show resolved Hide resolved
@teodanciu @lehins
Update NewCommittee action to use Credential and add new type `Comm…
44d65b3 
…ittee`:

namely: old committee and the expiration epoch for each new member.
Also update `EnactState` to reflect these changes
@lehins lehins force-pushed the td/newcommittee-improvements branch from 4863bdf to 44d65b3 Compare July 30, 2023 12:50
@lehins lehins enabled auto-merge July 30, 2023 12:50
@lehins lehins merged commit ecdb9c7 into master Jul 30, 2023
11 of 13 checks passed
@iohk-bors iohk-bors bot deleted the td/newcommittee-improvements branch July 30, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehins lehins lehins approved these changes

@aniketd aniketd aniketd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NewCommittee proposal needs more info
3 participants
@teodanciu @aniketd @lehins