Voting procedure map #3579
Merged
Voting procedure map #3579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
force-pushed
the
lehins/voting-procedure-map
branch
from
74fd20d
to
90a6043
Compare
lehins
force-pushed
the
lehins/voting-procedure-map
branch
from
90a6043
to
381c684
Compare
Soupstraw
reviewed
Jul 27, 2023
Soupstraw
reviewed
Jul 27, 2023
lehins
force-pushed
the
lehins/voting-procedure-map
branch
2 times, most recently
from
9439aaa
to
0e592d3
Compare
This change is necessary in order to enforce uniqueness of votes per transaction. It also simplifies the rules logic somewhat and significantly reduces the size of transaction when there are many votes by the same voter
lehins
force-pushed
the
lehins/voting-procedure-map
branch
from
0e592d3
to
d0989f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3542
The fix is slightly different than in the ticket. The
votingProceduresTxBodyLfield is switched to a nested Map that is enforced to not have any empty Maps on the second level by the decoder. Arbitrary instance also reflects this invariant.This approach reduced transaction size significantly when there many votes for the same Voter, which is expected to be a common case. Also simplifies rules in logic a bit.
Also bumps up versions for
small-steps-testandcardano-ledger-shelley-test, since those provide support for GHC-9.6, but haven't been released yet.Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)