Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename CommitteeCert into a GovCert #3585

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Conversation

lehins
Copy link
Contributor

@lehins lehins commented Jul 27, 2023

Description

Fixes #3583

This PR does the rename:

  • ConwayCommitteeCert -> ConwayGovCert
  • ConwayTxCertCommittee -> ConwayTxCertGov

As well as enforces witnesses for DRep unregistration certificates: both scripts and keys

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@lehins lehins force-pushed the lehins/fixup-drep-certificates branch from c7e98bf to f6fadb3 Compare July 27, 2023 21:59
@lehins lehins marked this pull request as ready for review July 27, 2023 21:59
@lehins lehins requested a review from aniketd July 28, 2023 10:19
Copy link
Contributor

@aniketd aniketd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 committee is the worst english word to type 😉 Thank you!

@lehins lehins merged commit 454a7d3 into master Jul 28, 2023
13 of 15 checks passed
@iohk-bors iohk-bors bot deleted the lehins/fixup-drep-certificates branch July 28, 2023 11:28
@lehins
Copy link
Contributor Author

lehins commented Jul 28, 2023

@aniketd, I think "Mississippi" is slightly worse than "Committee" for typing 😜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract DRep certificates from ConwayCommitteeCert
2 participants