Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename key roles #3588

Merged
merged 4 commits into from
Jul 29, 2023
Merged

Rename key roles #3588

merged 4 commits into from
Jul 29, 2023

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Jul 28, 2023 •
edited

Description

Resolves #3565

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@aniketd aniketd requested a review from lehins July 28, 2023 15:30
@aniketd aniketd changed the title Aniketd/key roles rename Rename key roles Jul 28, 2023
@lehins lehins enabled auto-merge (squash) July 28, 2023 15:36
lehins
lehins approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you

@aniketd aniketd disabled auto-merge July 29, 2023 14:15
@aniketd aniketd enabled auto-merge July 29, 2023 14:16
@aniketd aniketd merged commit 60b4424 into master Jul 29, 2023
10 of 12 checks passed
@iohk-bors iohk-bors bot deleted the aniketd/key-roles-rename branch July 29, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehins lehins lehins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename key roles
2 participants
@aniketd @lehins