Added pulsing incremental computation of the DRep distribution #3592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
requested changes
Aug 1, 2023
There was a problem hiding this comment.
I think this looks great. Just some minor cleanup is needed and one minor question.
We still need to remember all of the votes at the epoch boundary as well, so they don't change, but that will be done as a separate ticket in #3590
teodanciu
reviewed
Aug 1, 2023
TimSheard
force-pushed
the
ts-DRepDistr
branch
6 times, most recently
from
c3edea6
to
921173b
Compare
This was added as a 3rd field to VState. Changed Serialisation and Golden Tests. Integrated the DRepDistr into NEWEPOCH, EPOCH, RATIFY, and TICK rules. Reorgnized (and added missing) Lenses for types in and below NewEpochState
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added module Cardano.Ledger.DRepDistr, defines pulsing DRepDistr.
Integrated the DRepDistr into NEWEPOCH, EPOCH, and RATIFY rules.
Description
Addresses issue #3446
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)