Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ProposalProcedure return address to be a RewardAcnt #3597

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

teodanciu
Copy link
Contributor

Description

Closes #3594

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@teodanciu
Copy link
Contributor Author

I assume scriptsNeeded doesn't have to be updated for this, please correct me if I'm wrong

Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During a meeting yesterday we figured out a discrepancy. This has to be a RewardAcnt, not just a Credential

eras/conway/impl/src/Cardano/Ledger/Conway/Governance.hs Outdated Show resolved Hide resolved
@teodanciu teodanciu force-pushed the td/pproc-return-cred branch 2 times, most recently from 9e64fde to 898efd4 Compare August 4, 2023 12:26
@teodanciu
Copy link
Contributor Author

I updated it to be a RewardAcnt, however, I haven't used the Network anywhere.
I assume it will be needed (otherwise why have it), but not sure if at this point. Maybe in the way we insert in UMap in Epoch rule?

@lehins
Copy link
Contributor

lehins commented Aug 4, 2023

We'll only need to validate that the NetworkId matches the network we are running. That's all.

See this ticket I created: #3603

Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thank you!

eras/conway/impl/CHANGELOG.md Outdated Show resolved Hide resolved
@teodanciu teodanciu changed the title Update ProposalProcedure return address to be a Credential Update ProposalProcedure return address to be a RewardAcnt Aug 4, 2023
@teodanciu teodanciu enabled auto-merge (rebase) August 4, 2023 12:47
@teodanciu teodanciu merged commit d42dbc0 into master Aug 4, 2023
9 checks passed
@iohk-bors iohk-bors bot deleted the td/pproc-return-cred branch August 4, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change pProcReturnAddr to Credential
2 participants