Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added DRep anchors #3601

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Added DRep anchors #3601

merged 2 commits into from
Aug 9, 2023

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Aug 2, 2023 •
edited

Description

closes #3553

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Soupstraw Soupstraw closed this Aug 7, 2023
@Soupstraw Soupstraw reopened this Aug 7, 2023
@Soupstraw Soupstraw force-pushed the jj/drep-anchors branch 3 times, most recently from b95ad73 to 89eb9bf Compare August 7, 2023 14:56
@Soupstraw Soupstraw marked this pull request as ready for review August 7, 2023 15:56
@Soupstraw Soupstraw marked this pull request as draft August 7, 2023 15:57
@lehins lehins mentioned this pull request Aug 7, 2023
Closed
@Soupstraw Soupstraw force-pushed the jj/drep-anchors branch 2 times, most recently from cc5f5cb to c5d66cb Compare August 8, 2023 11:24
@Soupstraw Soupstraw marked this pull request as ready for review August 8, 2023 11:25
aniketd
aniketd approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@aniketd aniketd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙌 other than the comments already made.

@Soupstraw Soupstraw mentioned this pull request Aug 8, 2023
Closed
teodanciu
teodanciu approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Soupstraw Soupstraw force-pushed the jj/drep-anchors branch 4 times, most recently from dc4c4db to 47b2cf2 Compare August 9, 2023 10:06
@Soupstraw Soupstraw enabled auto-merge (rebase) August 9, 2023 10:57
@Soupstraw Soupstraw mentioned this pull request Aug 9, 2023
Closed
@Soupstraw Soupstraw merged commit 49cc2d6 into master Aug 9, 2023
10 checks passed
@iohk-bors iohk-bors bot deleted the jj/drep-anchors branch August 9, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehins lehins lehins left review comments

@aniketd aniketd aniketd approved these changes

@teodanciu teodanciu teodanciu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DRep anchors
4 participants
@Soupstraw @aniketd @teodanciu @lehins