Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename governance to gov #3607

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Rename governance to gov #3607

merged 1 commit into from
Aug 8, 2023

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Aug 7, 2023

Description

Resolves #3544

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@aniketd aniketd changed the title Aniketd/rename governance to gov Rename governance to gov Aug 7, 2023
@aniketd aniketd force-pushed the aniketd/rename-governance-to-gov branch from cd279e6 to 0a4053a Compare August 7, 2023 09:49
@aniketd aniketd marked this pull request as ready for review August 7, 2023 10:14
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of things need a change, but otherwise looks great.

eras/conway/impl/CHANGELOG.md Outdated Show resolved Hide resolved
eras/conway/impl/CHANGELOG.md Outdated Show resolved Hide resolved
eras/conway/test-suite/cddl-files/conway.cddl Outdated Show resolved Hide resolved
eras/conway/test-suite/cddl-files/conway.cddl Outdated Show resolved Hide resolved
libs/cardano-ledger-api/src/Cardano/Ledger/Api.hs Outdated Show resolved Hide resolved
libs/cardano-ledger-api/src/Cardano/Ledger/Api/Gov.hs Outdated Show resolved Hide resolved
eras/shelley/impl/CHANGELOG.md Show resolved Hide resolved
@aniketd aniketd force-pushed the aniketd/rename-governance-to-gov branch 2 times, most recently from 6e679a6 to 11ce833 Compare August 8, 2023 12:31
@aniketd aniketd requested a review from lehins August 8, 2023 12:31
@aniketd aniketd force-pushed the aniketd/rename-governance-to-gov branch from 11ce833 to 803db4f Compare August 8, 2023 12:55
- `GovernanceActionState` to `GovActionState`
- `GovernanceActionIx` to `GovActionIx`
- `GovernanceActionId` to `GovActionId`
- `GovernanceAction` to `GovAction`
- `EraGovernance` to `EraGov`
- `GovernanceState` to `GovState`
- `witsVKeyNeededNoGovernance` to `witsVKeyNeededNoGov`
- `witsVKeyNeededGovernance` to `witsVKeyNeededGov`
- `utxosGovernance` to `utxosGovState`
- `ConwayGovState` to `GovActionsState`
- `ConwayGov(ernance)` to `ConwayGovState`
@lehins lehins force-pushed the aniketd/rename-governance-to-gov branch from 803db4f to cfd6a46 Compare August 8, 2023 18:45
@lehins lehins enabled auto-merge August 8, 2023 18:46
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! Thank you!

@lehins lehins merged commit de526c8 into master Aug 8, 2023
12 checks passed
@iohk-bors iohk-bors bot deleted the aniketd/rename-governance-to-gov branch August 8, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Governance* to Gov* for all relevant types and function names
2 participants