Avoid using sequence of tuples, by adding GovActionId to GovActionState #3637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soupstraw
force-pushed
the
jj/govaction-datatype
branch
from
2059b49
to
41a4f60
Compare
Soupstraw
force-pushed
the
jj/govaction-datatype
branch
from
41a4f60
to
75626d3
Compare
teodanciu
reviewed
Aug 11, 2023
lehins
reviewed
Aug 14, 2023
Soupstraw
force-pushed
the
jj/govaction-datatype
branch
2 times, most recently
from
8d7762e
to
90fc897
Compare
lehins
approved these changes
Aug 15, 2023
teodanciu
reviewed
Aug 15, 2023
teodanciu
reviewed
Aug 15, 2023
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Examples/ConwayFeatures.hs
Outdated
Show resolved
Hide resolved
teodanciu
reviewed
Aug 15, 2023
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Examples/ConwayFeatures.hs
Outdated
Show resolved
Hide resolved
Soupstraw
force-pushed
the
jj/govaction-datatype
branch
4 times, most recently
from
4fa9fcf
to
69a4a52
Compare
teodanciu
approved these changes
Aug 18, 2023
lehins
force-pushed
the
jj/govaction-datatype
branch
from
69a4a52
to
d119db1
Compare
lehins
changed the title
lehins
reviewed
Aug 21, 2023
lehins
reviewed
Aug 21, 2023
to reflect breaking changes
teodanciu
force-pushed
the
jj/govaction-datatype
branch
from
45bc2a5
to
a79e78d
Compare
teodanciu
reviewed
Aug 21, 2023
aniketd
reviewed
Aug 22, 2023
|
|
||
| ## 1.7.0.0 | ||
|
|
||
| * Add `Network` validation for `ProposalProcedure` and `TreasuryWithdrawals` in GOV #3659 |
There was a problem hiding this comment.
Did this line just get removed? Should it be part of 1.8 instead? @Soupstraw
There was a problem hiding this comment.
Oops, looks like I removed it by mistake. Yes, I think it should be part of 1.8 because 1.7 was released at (bbdfc3f) before this commit . Sorry!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #3578
This PR fixes the above ticket in a different way. Namely, by adding
govActionIdto theGovActionState. This approach is very similar to howPoolParamsare implemented.Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)