Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust versions, bounds and CHANGELOGs to account for the latest release #3661

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

lehins
Copy link
Contributor

@lehins lehins commented Aug 18, 2023

Description

Recent release requires some adjustments on master.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@aniketd
Copy link
Contributor

aniketd commented Aug 18, 2023

If I understand correctly, we bump version numbers on master after every release, so that ongoing development can easily add changelog under the next bump, or bump it further, whichever is necessary?

@lehins
Copy link
Contributor Author

lehins commented Aug 18, 2023

If I understand correctly, we bump version numbers on master after every release, so that ongoing development can easily add changelog under the next bump, or bump it further, whichever is necessary?

@aniketd Yes, this is the step 4 in the release process

@lehins lehins force-pushed the lehins/post-release-changelog-adjustments branch from a31ff25 to c386199 Compare August 18, 2023 13:17
@aniketd aniketd self-requested a review August 18, 2023 13:47
Copy link
Contributor

@aniketd aniketd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙌

@lehins lehins force-pushed the lehins/post-release-changelog-adjustments branch from c386199 to bcc29d6 Compare August 18, 2023 15:45
@lehins lehins enabled auto-merge August 18, 2023 15:47
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@lehins lehins merged commit 431d56c into master Aug 18, 2023
11 of 13 checks passed
@iohk-bors iohk-bors bot deleted the lehins/post-release-changelog-adjustments branch August 18, 2023 19:20
@lehins lehins restored the lehins/post-release-changelog-adjustments branch August 18, 2023 19:50
@lehins lehins deleted the lehins/post-release-changelog-adjustments branch August 18, 2023 19:50
@lehins lehins mentioned this pull request Aug 28, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants