Equality on raw types #3662
Merged
Equality on raw types #3662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
force-pushed
the
lehins/post-release-changelog-adjustments
branch
from
a31ff25
to
c386199
Compare
lehins
force-pushed
the
lehins/equality-on-raw-types
branch
from
a19c892
to
276e841
Compare
lehins
force-pushed
the
lehins/equality-on-raw-types
branch
from
276e841
to
6611836
Compare
lehins
force-pushed
the
lehins/post-release-changelog-adjustments
branch
from
c386199
to
bcc29d6
Compare
lehins
changed the base branch from
lehins/post-release-changelog-adjustments
to
master
lehins
force-pushed
the
lehins/equality-on-raw-types
branch
3 times, most recently
from
9fb7567
to
2637323
Compare
teodanciu
reviewed
Aug 23, 2023
teodanciu
reviewed
Aug 23, 2023
lehins
force-pushed
the
lehins/equality-on-raw-types
branch
from
2637323
to
aeca1ff
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
teodanciu
reviewed
Aug 23, 2023
teodanciu
reviewed
Aug 23, 2023
teodanciu
reviewed
Aug 23, 2023
* Provide `EqRaw` instances for `TxCert`, `TxAuxData`, `TxWits`, `Script, `TxBody` and `Tx` for each era that defines one * Require and provide `ToExpr` instances for `TxCert`, `TxAuxData`, `Script` and `TxBody` * Simplify `specTxAuxDataUpgrade` test
lehins
force-pushed
the
lehins/equality-on-raw-types
branch
from
aeca1ff
to
b922b2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
EqRawclass that can be used to compare the Haskell type ignoring the underlying binary reopresentation for memoized times, regardless if they use MemoBytes or not. Default implementation, however, uses the MemoBytes representation, which will work for flat types based on MemoBytes, which is the majority of them. This approach simplifies the testing a bit.@nc6 I took your suggestion of creating a separate class for this concept, it works out slightly nicer, because it will make tests less complex.
As a bonus this PR also adds ToExpr instances for some of the core types.
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)