Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track proposal expiry #3664

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Track proposal expiry #3664

merged 1 commit into from
Aug 22, 2023

Conversation

aniketd
Copy link
Contributor

@aniketd aniketd commented Aug 21, 2023 •
edited

Description

Closes #3642

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@aniketd aniketd force-pushed the aniketd/track-proposal-expiry branch from 20b91b5 to 56946d9 Compare August 21, 2023 16:34
lehins
lehins requested changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Few important changes are needed though

eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Gov.hs Outdated Show resolved Hide resolved
libs/cardano-ledger-pretty/cardano-ledger-pretty.cabal Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Ratify.hs Outdated Show resolved Hide resolved
eras/conway/impl/CHANGELOG.md Outdated Show resolved Hide resolved
eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Ratify.hs Outdated Show resolved Hide resolved
@aniketd aniketd force-pushed the aniketd/track-proposal-expiry branch from c76483e to ccbee18 Compare August 22, 2023 11:13
@aniketd aniketd force-pushed the aniketd/track-proposal-expiry branch from ccbee18 to 1beddd3 Compare August 22, 2023 13:32
@aniketd aniketd mentioned this pull request Aug 22, 2023
Merged
9 tasks
lehins
lehins approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lehins lehins enabled auto-merge August 22, 2023 15:07
@lehins lehins merged commit e522aaf into master Aug 22, 2023
11 of 12 checks passed
@iohk-bors iohk-bors bot deleted the aniketd/track-proposal-expiry branch August 22, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lehins lehins lehins approved these changes

@WhatisRT WhatisRT Awaiting requested review from WhatisRT

@TimSheard TimSheard Awaiting requested review from TimSheard

@Soupstraw Soupstraw Awaiting requested review from Soupstraw

@teodanciu teodanciu Awaiting requested review from teodanciu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Track Proposal Procedure Expiry
3 participants
@aniketd @teodanciu @lehins