-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added RATIFY thresholds #3674
Added RATIFY thresholds #3674
Conversation
707b6d3
to
3c7c027
Compare
45b27bb
to
b18e2ac
Compare
6099ea7
to
5aa3316
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a clever trick with Ap
. There is one minor issue with it, which I already mentioned during a meeting that implementation of pparamsGroup
depends on the correct order of arguments, but we can solve it at a later point.
Overall looks great. Changes I suggested will be good in order to improve clarity and performance, despite that they slightly diverge from the spec.
a0de0f4
to
3d55d17
Compare
b0c1d69
to
b7688f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minor adjustments are still needed, but other than that it looks great. Thank you.
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Examples/ConwayWithdrawalDelay.hs
Outdated
Show resolved
Hide resolved
4bcee72
to
9aa10b4
Compare
Pull request was closed
9aa10b4
to
330b42d
Compare
fcd8abc
to
a2f1ce2
Compare
a2f1ce2
to
6083501
Compare
Description
Implemented ratification thresholds. I used a free applicative to assign the fields of
PParams
into groups. The applicative adds some type safety in ensuring that all the fields are handled while also making it easy to gather all the modified groups in aPParamsUpdate
.closes #3524
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)