Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conway Genesis additions #3681

Merged
merged 4 commits into from
Sep 4, 2023
Merged

Conway Genesis additions #3681

merged 4 commits into from
Sep 4, 2023

Conversation

teodanciu
Copy link
Contributor

@teodanciu teodanciu commented Aug 25, 2023

Description

Closes #3652

  • Adds two fields to ConwayGenesis: Constitution and Committee
  • Updates Conway Translation to create EnactState using the two new fields from ConwayGenesis
  • Also added a trivial JSON gold test, to prevent accidental changes of the json serialization

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@teodanciu teodanciu marked this pull request as draft August 25, 2023 23:22
@teodanciu teodanciu changed the title Td/conway genesis WIP: Conway Genesis additions Aug 25, 2023
@teodanciu teodanciu force-pushed the td/conway-genesis branch 4 times, most recently from 6557d0b to c810cce Compare August 29, 2023 16:05
@teodanciu teodanciu marked this pull request as ready for review August 29, 2023 16:06
@teodanciu teodanciu changed the title WIP: Conway Genesis additions Conway Genesis additions Aug 30, 2023
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. Couple of common mistakes, but all easily fixable

@teodanciu
Copy link
Contributor Author

Wow, it seems I don't understand at all how to use Crypto, EraCrypto, Era, ConwayEra in a correct way (the fact that it compiles is not sufficient for that)!
I will try to deduce from your corrections, @lehins , thank you!

@teodanciu teodanciu force-pushed the td/conway-genesis branch 3 times, most recently from 872eeee to 6da0786 Compare September 1, 2023 15:24
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

@lehins lehins merged commit 453d19d into master Sep 4, 2023
10 of 22 checks passed
@iohk-bors iohk-bors bot deleted the td/conway-genesis branch September 4, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand Conway Genesis
2 participants