Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed ProtVer from EnactState #3705

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Removed ProtVer from EnactState #3705

merged 2 commits into from
Sep 5, 2023

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Sep 5, 2023

Description

Remove the protocol version field from EnactState and use the one in PParams instead.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lehins lehins merged commit 5fbcf6e into master Sep 5, 2023
12 of 165 checks passed
@iohk-bors iohk-bors bot deleted the jj/remove-protver branch September 5, 2023 20:02
lehins added a commit that referenced this pull request Sep 5, 2023
lehins added a commit that referenced this pull request Sep 5, 2023
lehins added a commit that referenced this pull request Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants