-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply enacted treasury withdrawals #3748
Conversation
d8e841b
to
e123bbb
Compare
This needs a bit of rework (potential underflow and some known guarantees). |
a019dc1
to
cd8871b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are still missing some parts from the spec, like this one:
https://github.com/input-output-hk/formal-ledger-specifications/blob/d8260e001e248725a01335253ce33f35d1656fe7/src/Ledger/Chain.lagda#L84
We'll talk more about it during the meeting, but I think you haven't looked deeply into how ensTreasury
field works in EnactState and how it relates to `epochStateTreasuryL
Also, add lenses ensWithdrawalsL, ensTreasuryL and epochStateTreasuryL.
cd8871b
to
0c95a90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect! 👍
Also, add lenses ensWithdrawalsL, ensTreasuryL and epochStateTreasuryL. Patched version
Description
Closes #3736
Also add lenses
ensWithdrawalsL
,ensTreasuryL
andepochStateTreasuryL
.Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)