-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move ImpTest
to Shelley testlib
#3782
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soupstraw
force-pushed
the
jj/imp-reorganize
branch
7 times, most recently
from
October 10, 2023 13:52
bb0bc9a
to
11098a0
Compare
Soupstraw
force-pushed
the
jj/imp-reorganize
branch
4 times, most recently
from
October 10, 2023 14:49
8b343e2
to
0b9d687
Compare
Soupstraw
force-pushed
the
jj/imp-reorganize
branch
from
October 10, 2023 15:21
0b9d687
to
0082442
Compare
Soupstraw
force-pushed
the
jj/imp-reorganize
branch
3 times, most recently
from
October 11, 2023 12:05
9baeb8a
to
606b344
Compare
Soupstraw
force-pushed
the
jj/imp-reorganize
branch
8 times, most recently
from
October 12, 2023 15:09
161ce2d
to
72c3093
Compare
Soupstraw
force-pushed
the
jj/imp-reorganize
branch
12 times, most recently
from
October 17, 2023 10:25
db73161
to
17b7eb7
Compare
lehins
requested changes
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good. I don't really like reshuffling of witsVKeyNeeded
.
eras/shelley/impl/testlib/Test/Cardano/Ledger/Shelley/ImpTest.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-core/testlib/Test/Cardano/Ledger/Core/Utils.hs
Outdated
Show resolved
Hide resolved
eras/shelley/impl/testlib/Test/Cardano/Ledger/Shelley/ImpTest.hs
Outdated
Show resolved
Hide resolved
Soupstraw
force-pushed
the
jj/imp-reorganize
branch
3 times, most recently
from
October 18, 2023 09:41
e90d564
to
ae7efe7
Compare
lehins
reviewed
Oct 18, 2023
Soupstraw
force-pushed
the
jj/imp-reorganize
branch
5 times, most recently
from
October 19, 2023 10:36
9415b32
to
7e9eacf
Compare
Soupstraw
force-pushed
the
jj/imp-reorganize
branch
from
October 19, 2023 10:42
7e9eacf
to
e14087d
Compare
Moved ImpTest to Shelley testlib Add EraImpTest instances for all eras
Soupstraw
force-pushed
the
jj/imp-reorganize
branch
from
October 19, 2023 11:00
e14087d
to
3ee506b
Compare
lehins
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful! Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved
ImpTest
to core and added theEraImpTest
class together with an instance in theConway
era. Moved some tests intoImpTestSpec
in Shelley and made it run in every era.Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)