Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ImpTest to Shelley testlib #3782

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Move ImpTest to Shelley testlib #3782

merged 1 commit into from
Oct 19, 2023

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Oct 6, 2023

Description

Moved ImpTest to core and added the EraImpTest class together with an instance in the Conway era. Moved some tests into ImpTestSpec in Shelley and made it run in every era.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Soupstraw Soupstraw force-pushed the jj/imp-reorganize branch 7 times, most recently from bb0bc9a to 11098a0 Compare October 10, 2023 13:52
@Soupstraw Soupstraw marked this pull request as ready for review October 10, 2023 14:01
@Soupstraw Soupstraw force-pushed the jj/imp-reorganize branch 4 times, most recently from 8b343e2 to 0b9d687 Compare October 10, 2023 14:49
@Soupstraw Soupstraw marked this pull request as draft October 11, 2023 09:24
@Soupstraw Soupstraw force-pushed the jj/imp-reorganize branch 3 times, most recently from 9baeb8a to 606b344 Compare October 11, 2023 12:05
@Soupstraw Soupstraw marked this pull request as ready for review October 11, 2023 12:10
@Soupstraw Soupstraw force-pushed the jj/imp-reorganize branch 8 times, most recently from 161ce2d to 72c3093 Compare October 12, 2023 15:09
@Soupstraw Soupstraw force-pushed the jj/imp-reorganize branch 12 times, most recently from db73161 to 17b7eb7 Compare October 17, 2023 10:25
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good. I don't really like reshuffling of witsVKeyNeeded.

libs/cardano-ledger-core/src/Cardano/Ledger/UTxO.hs Outdated Show resolved Hide resolved
libs/cardano-ledger-core/src/Cardano/Ledger/UTxO.hs Outdated Show resolved Hide resolved
eras/alonzo/impl/src/Cardano/Ledger/Alonzo/UTxO.hs Outdated Show resolved Hide resolved
eras/alonzo/impl/CHANGELOG.md Outdated Show resolved Hide resolved
libs/cardano-ledger-core/CHANGELOG.md Outdated Show resolved Hide resolved
@Soupstraw Soupstraw force-pushed the jj/imp-reorganize branch 3 times, most recently from e90d564 to ae7efe7 Compare October 18, 2023 09:41
Moved ImpTest to Shelley testlib
Add EraImpTest instances for all eras
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! Thank you!

@lehins lehins enabled auto-merge October 19, 2023 11:17
@lehins lehins merged commit 2a56b91 into master Oct 19, 2023
9 of 14 checks passed
@iohk-bors iohk-bors bot deleted the jj/imp-reorganize branch October 19, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants