Enhance CommitteeMembersState query to return quorum and NoConfidence:
#3808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodanciu
reviewed
Oct 25, 2023
libs/cardano-ledger-api/test/Test/Cardano/Ledger/Api/State/QuerySpec.hs
Outdated
Show resolved
Hide resolved
lehins
force-pushed
the
lehins/reflect-no-confidence
branch
from
f5d3a94
to
e669541
Compare
teodanciu
reviewed
Oct 25, 2023
When designing the query we forgot about two important pieces of information relevant for the constitutional commitee, namely the quorum value and the overall presence of the committee. There is a difference between an empty committee and no committe, the latter means that the system is in a state of no confidence.
lehins
force-pushed
the
lehins/reflect-no-confidence
branch
from
e669541
to
26db4a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When designing the query we forgot about two important pieces of information relevant for the constitutional commitee, namely the quorum value and the overall presence of the committee. There is a difference between an empty committee and no committe, the latter means that the system is in a state of no confidence.
Checklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)