Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cardano-ledger-conformance #3839

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Added cardano-ledger-conformance #3839

merged 1 commit into from
Nov 1, 2023

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Nov 1, 2023

Description

Adds the cardano-ledger-conformance package, which imports the executable spec generated from Agda. Currently it pulls the generated code from Github, but hopefully we can do that via Nix in the future without the need for an additional repo.

Resolves steps 0 and 1 in #3811.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Soupstraw Soupstraw marked this pull request as ready for review November 1, 2023 11:49
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Soupstraw Soupstraw enabled auto-merge (rebase) November 1, 2023 14:05
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Soupstraw Soupstraw merged commit 7297c1b into master Nov 1, 2023
8 of 39 checks passed
@iohk-bors iohk-bors bot deleted the jj/conformance-0-repo branch November 1, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants