Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mappings to Agda types #3844

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Add mappings to Agda types #3844

merged 1 commit into from
Nov 6, 2023

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented Nov 2, 2023

Description

Adds the SpecCastable type class that maps the implementation types to spec types.

Resolves task 2 of #3811

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

@Soupstraw Soupstraw force-pushed the jj/conformance-agda-rep branch 4 times, most recently from 0fe90e9 to 74655ea Compare November 3, 2023 10:45
@Soupstraw Soupstraw requested a review from lehins November 3, 2023 10:46
@Soupstraw Soupstraw marked this pull request as ready for review November 3, 2023 10:46
@Soupstraw Soupstraw force-pushed the jj/conformance-agda-rep branch 4 times, most recently from 768f8b8 to 1404f82 Compare November 3, 2023 12:21
Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bunch of little suggestions, otherwise looks great!

One thing I am not totally sold on is the name SpecCastable. This is more of a translation that can fail, rather than casting of one type to another. SpecTrans maybe? In any case, it's up to you, this is also only a suggestion

@Soupstraw Soupstraw force-pushed the jj/conformance-agda-rep branch 10 times, most recently from 97a5618 to 074e8dc Compare November 6, 2023 10:35
@Soupstraw Soupstraw enabled auto-merge (rebase) November 6, 2023 11:31
@Soupstraw Soupstraw merged commit aba6a87 into master Nov 6, 2023
9 of 42 checks passed
@iohk-bors iohk-bors bot deleted the jj/conformance-agda-rep branch November 6, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants