-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mappings to Agda types #3844
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehins
reviewed
Nov 2, 2023
libs/cardano-ledger-conformance/src/Test/Cardano/Ledger/Conformance.hs
Outdated
Show resolved
Hide resolved
Soupstraw
force-pushed
the
jj/conformance-agda-rep
branch
4 times, most recently
from
November 3, 2023 10:45
0fe90e9
to
74655ea
Compare
Soupstraw
force-pushed
the
jj/conformance-agda-rep
branch
4 times, most recently
from
November 3, 2023 12:21
768f8b8
to
1404f82
Compare
lehins
approved these changes
Nov 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bunch of little suggestions, otherwise looks great!
One thing I am not totally sold on is the name SpecCastable
. This is more of a translation that can fail, rather than casting of one type to another. SpecTrans
maybe? In any case, it's up to you, this is also only a suggestion
libs/cardano-ledger-conformance/src/Test/Cardano/Ledger/Conformance.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-conformance/src/Test/Cardano/Ledger/Conformance.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-conformance/src/Test/Cardano/Ledger/Conformance.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-conformance/src/Test/Cardano/Ledger/Conformance.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-conformance/src/Test/Cardano/Ledger/Conformance.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-conformance/src/Test/Cardano/Ledger/Conformance.hs
Outdated
Show resolved
Hide resolved
Soupstraw
force-pushed
the
jj/conformance-agda-rep
branch
10 times, most recently
from
November 6, 2023 10:35
97a5618
to
074e8dc
Compare
Soupstraw
force-pushed
the
jj/conformance-agda-rep
branch
from
November 6, 2023 10:48
074e8dc
to
162b39e
Compare
This was referenced Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the
SpecCastable
type class that maps the implementation types to spec types.Resolves task 2 of #3811
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)