Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert argument order swap. #3846

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Conversation

lehins
Copy link
Contributor

@lehins lehins commented Nov 3, 2023

Description

This change was accidentally merge into master in #3836

Reversion of this change is desired since it can be dangerous if a wrong version of cardano-ledger-alonzo gets used somehow by cardano-ledegr-conway

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

Reversion of this change is desired since it can be dangerous if a wrong
version of cardano-ledger-alonzo gets used somehow
@lehins lehins requested a review from teodanciu November 3, 2023 16:26
Copy link
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like un-f to me 😆
Which is good.
Looks good to me

@lehins lehins enabled auto-merge November 3, 2023 16:56
@lehins lehins merged commit 40c3468 into master Nov 3, 2023
11 of 43 checks passed
@iohk-bors iohk-bors bot deleted the lehins/revert-argument-order-swap branch November 3, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants