Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to support property tests on Traces with simple Tx with DRep related Certs #3868

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

TimSheard
Copy link
Contributor

@TimSheard TimSheard commented Nov 11, 2023

Added features for chains of simple transactions.
Added Univ for DRep and DRepState,
Better constraints for VState, Added constraints for EpochState and NewEpochState.
New vars for Conway PParams, and needed (Rep era t).
Added missing Conway PParams fields, added abstractPParams, and pcParams.
Added module DrepCertTx which generates simple Tx with just Conway DRep Certs.
Added RootTarget for DRepPulser. Introduced idea of RootTarget for Pairs.
Added Virtual RootTarget like Lensed with additional name.
Added a new HasTrace instances, simplified MockChain
Added STS (MOCKCHAIN era) instance and helper functions.
Fixed pot Equal obligation in Pool Reap and problems with tracking obligations.
Made 'There are no "stakepools to choose an issuer from" a discard.
Added property tests on traces with simple Tx with certs on DReps.

Fixes #3610

Description

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated
  • When applicable, versions are updated in .cabal and CHANGELOG.md files according to the
    versioning process.
  • The version bounds in .cabal files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
  • All visible changes are prepended to the latest section of a CHANGELOG.md for the affected packages. New section is never added with the code changes. (See RELEASING.md)
  • Code is formatted with fourmolu (use scripts/fourmolize.sh)
  • Cabal files are formatted (use scripts/cabal-format.sh)
  • hie.yaml has been updated (use scripts/gen-hie.sh)
  • Self-reviewed the diff

Copy link
Contributor

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

…and DRepState,

Better constraints for VState, New vars for Conway PParams, and needed (Rep era t).
Added missing Conway PParams fields, added abstractPParams, and pcParams.
Added drepCertTx which generates simple Tx with just Conway DRep Certs.
Added file DrepCertTx.hs
Added RootTarget for DRepPulser. Introduced idea of RootTarget for Pairs. Virtual RootTarget like Lensed with additional name.
Added Preds/NewEpochState, started some new HasTrace instances, simplified MockChain
Finished  STS (MOCKCHAIN era) instance and helper functions.
Still fixing pot Equal obligation in Pool Reap. Problems with trackin obligations.
Made 'There are no stakepools to choose an issuer from. a discard.
Added property tests on traces with simple Tx with certs on DReps.
Fixed Member vs NonMember error in Preds/Certs.hs (Joosep)
@TimSheard TimSheard enabled auto-merge (rebase) November 17, 2023 13:56
@TimSheard TimSheard merged commit e6a8e3f into master Nov 17, 2023
9 checks passed
@iohk-bors iohk-bors bot deleted the ts-constrained-trace branch November 17, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Systematic simple, but long traces
4 participants