-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to support property tests on Traces with simple Tx with DRep related Certs #3868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimSheard
force-pushed
the
ts-constrained-trace
branch
from
November 11, 2023 13:06
46d4d29
to
210b244
Compare
Soupstraw
reviewed
Nov 13, 2023
Soupstraw
reviewed
Nov 13, 2023
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Lenses.hs
Outdated
Show resolved
Hide resolved
TimSheard
force-pushed
the
ts-constrained-trace
branch
2 times, most recently
from
November 13, 2023 18:40
38a4d90
to
e8d4231
Compare
Soupstraw
force-pushed
the
ts-constrained-trace
branch
from
November 14, 2023 12:21
e8d4231
to
115c129
Compare
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Preds/CertState.hs
Outdated
Show resolved
Hide resolved
TimSheard
force-pushed
the
ts-constrained-trace
branch
from
November 14, 2023 16:26
115c129
to
305495e
Compare
lehins
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Preds/NewEpochState.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Lenses.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Preds/LedgerState.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Preds/NewEpochState.hs
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Preds/PParams.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Ast.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Solver.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Solver.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Lenses.hs
Outdated
Show resolved
Hide resolved
libs/cardano-ledger-test/src/Test/Cardano/Ledger/Constrained/Preds/LedgerState.hs
Outdated
Show resolved
Hide resolved
TimSheard
force-pushed
the
ts-constrained-trace
branch
from
November 16, 2023 15:07
305495e
to
482fd4e
Compare
MaximilianAlgehed
approved these changes
Nov 16, 2023
TimSheard
force-pushed
the
ts-constrained-trace
branch
from
November 16, 2023 16:33
482fd4e
to
b5d8b42
Compare
…and DRepState, Better constraints for VState, New vars for Conway PParams, and needed (Rep era t). Added missing Conway PParams fields, added abstractPParams, and pcParams. Added drepCertTx which generates simple Tx with just Conway DRep Certs. Added file DrepCertTx.hs Added RootTarget for DRepPulser. Introduced idea of RootTarget for Pairs. Virtual RootTarget like Lensed with additional name. Added Preds/NewEpochState, started some new HasTrace instances, simplified MockChain Finished STS (MOCKCHAIN era) instance and helper functions. Still fixing pot Equal obligation in Pool Reap. Problems with trackin obligations. Made 'There are no stakepools to choose an issuer from. a discard. Added property tests on traces with simple Tx with certs on DReps. Fixed Member vs NonMember error in Preds/Certs.hs (Joosep)
TimSheard
force-pushed
the
ts-constrained-trace
branch
from
November 17, 2023 12:49
b5d8b42
to
876858f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added features for chains of simple transactions.
Added Univ for DRep and DRepState,
Better constraints for VState, Added constraints for EpochState and NewEpochState.
New vars for Conway PParams, and needed (Rep era t).
Added missing Conway PParams fields, added abstractPParams, and pcParams.
Added module DrepCertTx which generates simple Tx with just Conway DRep Certs.
Added RootTarget for DRepPulser. Introduced idea of RootTarget for Pairs.
Added Virtual RootTarget like Lensed with additional name.
Added a new HasTrace instances, simplified MockChain
Added STS (MOCKCHAIN era) instance and helper functions.
Fixed pot Equal obligation in Pool Reap and problems with tracking obligations.
Made 'There are no "stakepools to choose an issuer from" a discard.
Added property tests on traces with simple Tx with certs on DReps.
Fixes #3610
Description
Checklist
.cabal
andCHANGELOG.md
files according to theversioning process.
.cabal
files for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.md
for the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu
(usescripts/fourmolize.sh
)scripts/cabal-format.sh
)hie.yaml
has been updated (usescripts/gen-hie.sh
)