Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Incremental ledger snapshot calculations are causing missed slot leader checks and block propagation delays #3392

Closed
orpheus-antpool opened this issue Nov 25, 2021 · 1 comment
Labels
bug Something isn't working comp: ledger type: bug Something is not working user type: external Created by an external user

Comments

@orpheus-antpool
Copy link

orpheus-antpool commented Nov 25, 2021

Internal/External
External

Area
Other: Stake Pool Operation

Summary
With increasing number of transactions, the incremental ledger snapshot calculations are becoming more complex and lead to missed slot leader checks and block propagation delays. This is independent of the major garbage collections which they trigger due to high memory usage and which also contribute to missed slot leader checks and block propagation delays. A particularly large difference is observable when comparing epoch 303 and epoch 304.

Expected behavior
Incremental ledger snapshot calculations should be performed in the background in a separate thread (to avoid blocking for longer than 1s) and at finer granularity (to avoid sudden memory spikes that trigger a chain of major garbage collections). If this is already running in a forkIO, then perhaps a foreign unsafe call is blocking something (in which case it would make sense to force it in a separate bound thread). Continuations could be a solution for finer grain calculations.

@orpheus-antpool orpheus-antpool added the bug Something isn't working label Nov 25, 2021
@dorin100 dorin100 added type: bug Something is not working user type: external Created by an external user comp: ledger labels Oct 24, 2022
@Jimbo4350
Copy link
Contributor

Closing this. If this is still relevant please reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working comp: ledger type: bug Something is not working user type: external Created by an external user
Projects
None yet
Development

No branches or pull requests

3 participants