Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI 1.35.4-RC1 crashing with a --cddl-format error #4597

Closed
gitmachtl opened this issue Nov 2, 2022 · 5 comments
Closed

CLI 1.35.4-RC1 crashing with a --cddl-format error #4597

gitmachtl opened this issue Nov 2, 2022 · 5 comments
Assignees
Labels
comp: cardano-cli tag: 1.35.4-rc1 type: bug Something is not working user type: external Created by an external user

Comments

@gitmachtl
Copy link
Contributor

gitmachtl commented Nov 2, 2022

$ cardano-cli version
cardano-cli 1.35.4 - linux-x86_64 - ghc-8.10
git rev 54998e843cf7d54eb1594ce191a261a112429ead

Using the --cddl-format flag with this revision in the transaction build-raw command causes an error:
Invalid option '--cddl-format'

Also the two lines

--cddl-format            Serialise in the ledger CDDL specified CBOR format.
 --cli-format            Serialise in the cardano-cli CBOR format.

are missing when checking the syntax with this revision like

cardano-cli transaction build-raw

if cddl-format is now the default and only format, the cli should still accept the flag for a while to change the calling in 3rd party tools.

@gitmachtl gitmachtl added the type: bug Something is not working label Nov 2, 2022
@Jimbo4350 Jimbo4350 removed the type: bug Something is not working label Nov 2, 2022
@Jimbo4350
Copy link
Contributor

Jimbo4350 commented Nov 2, 2022

Not a bug! We have deprecated the intermediate tx body format so you can no longer create it, however it can still be read. Lets put a breaking change note in the Changelog.

@Jimbo4350 Jimbo4350 changed the title [BUG] - CLI 1.35.4-RC1 crashing with a --cddl-format error CLI 1.35.4-RC1 crashing with a --cddl-format error Nov 2, 2022
@ada4profit
Copy link

It is not a bug, but many 3rd party tooling are depending on this parameter that is removed and as such it is breaking their solution. Basically it should have skipped this parameter if provided by the 3rd party solution, instead of giving an error message. This would have been a much more elegant solution dealing with this issue. Now 3rd parties have to go over their code and remove it on basis of something they were not informed about. Jmho.

@Jimbo4350
Copy link
Contributor

It is not a bug, but many 3rd party tooling are depending on this parameter that is removed and as such it is breaking their solution. Basically it should have skipped this parameter if provided by the 3rd party solution, instead of giving an error message. This would have been a much more elegant solution dealing with this issue. Now 3rd parties have to go over their code and remove it on basis of something they were not informed about. Jmho.

Ok, we can adjust it so that it does not fail.

@gitmachtl
Copy link
Contributor Author

thx @Jimbo4350, if the "dummy --cddl-format" flag is in for the next releases that would be perfect. so 3rd party tools have time to set a new node/cli min version in there tools and also remove the --cddl-flag from the calling commands.

@dorin100 dorin100 added type: bug Something is not working user type: external Created by an external user comp: cardano-cli tag: 1.35.4-rc1 labels Nov 4, 2022
iohk-bors bot added a commit that referenced this issue Nov 5, 2022
4617: Restore --cddl-format r=disassembler a=newhoggy

 as a hidden switch to avoid breaking 3rd party tooling.  The restore switch has no effect

Resolves #4597

Co-authored-by: John Ky <john.ky@iohk.io>
@gitmachtl
Copy link
Contributor Author

Thx @newhoggy, #4617 looks good. The transaction build/build-raw command is now working again without an error.
We will update the tools to remove the --cddl-format calling flag once 1.35.4 is released so we can set the minCliVersion to 1.35.4. Ready for a full removal starting with 1.36.*

iohk-bors bot added a commit that referenced this issue Nov 5, 2022
4617: Restore --cddl-format r=disassembler a=newhoggy

 as a hidden switch to avoid breaking 3rd party tooling.  The restore switch has no effect

Resolves #4597

Co-authored-by: John Ky <john.ky@iohk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp: cardano-cli tag: 1.35.4-rc1 type: bug Something is not working user type: external Created by an external user
Projects
None yet
Development

No branches or pull requests

5 participants