Allow assembling transactions with no witnesses #4408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LudvikGalois
requested review from
dcoutts,
Jimbo4350,
erikd,
newhoggy and
JaredCorduan
as code owners
LudvikGalois
force-pushed
the
ludvikgalois/no-wit-transactions
branch
from
6bb6447
to
c494863
Compare
newhoggy
approved these changes
Aug 31, 2022
Jimbo4350
requested changes
Sep 1, 2022
There was a problem hiding this comment.
@LudvikGalois have you confirmed this works on a local testnet?
I've tested that it works in so far as the command in the ticket works and you can assemble the transaction. I didn't check if it was actually a useful thing to do, and it seems like it's not, since it's impossible to submit that transaction. I'm not even sure how to redeem from a SimpleScript - the docs are out of date. |
LudvikGalois
force-pushed
the
ludvikgalois/no-wit-transactions
branch
from
c494863
to
1e355da
Compare
I have now confirmed that this allows spending of transactions from script addresses containing a script that requires no signatures. |
LudvikGalois
force-pushed
the
ludvikgalois/no-wit-transactions
branch
from
1e355da
to
9b0605a
Compare
13 tasks
Jimbo4350
approved these changes
Sep 27, 2022
|
This PR is stale because it has been open 45 days with no activity. |
LudvikGalois
force-pushed
the
ludvikgalois/no-wit-transactions
branch
from
9b0605a
to
442b357
Compare
LudvikGalois
requested review from
a team and
CarlosLopezDeLara
as code owners
Jimbo4350
force-pushed
the
ludvikgalois/no-wit-transactions
branch
3 times, most recently
from
9f7dd3c
to
62f99cd
Compare
It's possible to write a script which requires no signatures, for
example
```
{
"scripts": [
{
"keyHash": "df243ee05bbe556970c9f8b48088b90549b8c9e41a3380fdede62d16",
"type": "sig"
},
{
"keyHash": "452c6cc84a5430b4ff720d5692e0ce7f4d37b1f78a3bea99fdbab240",
"type": "sig"
},
{
"keyHash": "9b925a6b6462e0c7c48fc69a06d1e72d03da30655fd5af40e988140e",
"type": "sig"
}
],
"type": "atLeast",
"required": 0
}
```
As such, it should be supported by the CLI to assemble a transaction
with no witnesses. Both the assemble and sign commands have been updated
to support this.
Fixes: #3835
Jimbo4350
force-pushed
the
ludvikgalois/no-wit-transactions
branch
from
62f99cd
to
faa52ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible to write a script which requires no signatures, for
example
As such, it should be supported by the CLI to assemble a transaction
with no witnesses.
Fixes: #3835
Closes: #4471