Refactor genesis create command usage in cardano testnet
#4831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
force-pushed
the
jordan/refactor-genesis-create-cardano-testnet
branch
2 times, most recently
from
560db30
to
22350fb
Compare
Jimbo4350
requested review from
dcoutts,
erikd,
newhoggy,
JaredCorduan and
CarlosLopezDeLara
as code owners
Jimbo4350
force-pushed
the
jordan/refactor-genesis-create-cardano-testnet
branch
3 times, most recently
from
39d8190
to
761a00b
Compare
newhoggy
reviewed
Jan 26, 2023
newhoggy
approved these changes
Jan 27, 2023
Jimbo4350
force-pushed
the
jordan/refactor-genesis-create-cardano-testnet
branch
from
9bd7815
to
51b2360
Compare
Implement createByronUpdateProposal Reduce Babbage defaultTestnetOptions slot duration
Jimbo4350
force-pushed
the
jordan/refactor-genesis-create-cardano-testnet
branch
2 times, most recently
from
b43df4c
to
7942638
Compare
Implement createByronGenesis
Jimbo4350
force-pushed
the
jordan/refactor-genesis-create-cardano-testnet
branch
from
7942638
to
f2e4dd5
Compare
|
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 17, 2023
4831: Refactor `genesis create` command usage in cardano testnet r=Jimbo4350 a=Jimbo4350 Implement the following three modules: 1. Testnet.Commands.Genesis - Houses the refactoring of cli commands concerning genesis generation 2. Testnet.Commands.Governance - Houses the refactoring of cli commands concerning governance 3. Testnet.Options - Module that will house all the different `TestnetOptions` types. The aim is to only have one `TestnetOptions` type in the future. 4886: Preserve `ScriptData` bytes with `HashableScriptData` r=Jimbo4350 a=Jimbo4350 Resolves: #4433 Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
|
This PR was included in a batch that was canceled, it will be automatically retried |
iohk-bors bot
added a commit
that referenced
this pull request
Feb 17, 2023
4831: Refactor `genesis create` command usage in cardano testnet r=Jimbo4350 a=Jimbo4350 Implement the following three modules: 1. Testnet.Commands.Genesis - Houses the refactoring of cli commands concerning genesis generation 2. Testnet.Commands.Governance - Houses the refactoring of cli commands concerning governance 3. Testnet.Options - Module that will house all the different `TestnetOptions` types. The aim is to only have one `TestnetOptions` type in the future. Co-authored-by: Jordan Millar <jordan.millar@iohk.io>
|
Build failed: |
iohk-bors
bot
deleted the
jordan/refactor-genesis-create-cardano-testnet
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the following three modules:
Testnet.Commands.Genesis - Houses the refactoring of cli commands concerning genesis generation
Testnet.Commands.Governance - Houses the refactoring of cli commands concerning governance
Testnet.Options - Module that will house all the different
TestnetOptionstypes. The aim is to only have oneTestnetOptionstype in the future.