Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Less verbose node-to-client and node-to-node version logging #4911

Merged
merged 2 commits into from
Mar 10, 2023
Merged

Less verbose node-to-client and node-to-node version logging #4911

merged 2 commits into from
Mar 10, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Feb 23, 2023 •
edited
Loading

This is how it looks now:

[MacBook-:cardano.node.startup:Info:5] [2023-02-23 07:07:50.30 UTC]
node addresses:          0.0.0.0:3001, [::]:3001
local socket:            example/node-bft1/node.sock
node-to-node versions:   [7,8,9,10]
node-to-client versions: [9,10,11,12,13,14]

Resolves: #3433

@newhoggy newhoggy marked this pull request as ready for review February 23, 2023 07:08
coot
coot reviewed Feb 23, 2023
View reviewed changes
Copy link
Contributor

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, could you also use this function in here.

And please add a Changelog.md item, it's a breaking change.

@newhoggy newhoggy force-pushed the newhoggy/less-verbose-node-to-x-logging branch from 2fae9ca to 8e32215 Compare March 3, 2023 11:56
@newhoggy newhoggy requested a review from coot March 3, 2023 11:56
@newhoggy
Copy link
Contributor Author

newhoggy commented Mar 3, 2023

Change log updated.

@newhoggy newhoggy force-pushed the newhoggy/less-verbose-node-to-x-logging branch from 8e32215 to 5d7cbec Compare March 7, 2023 05:01
@newhoggy newhoggy added this pull request to the merge queue Mar 7, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 7, 2023
@newhoggy newhoggy force-pushed the newhoggy/less-verbose-node-to-x-logging branch from 5d7cbec to 74c2b28 Compare March 8, 2023 03:06
@newhoggy newhoggy enabled auto-merge March 8, 2023 03:06
@newhoggy newhoggy added this pull request to the merge queue Mar 8, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 8, 2023
@newhoggy newhoggy force-pushed the newhoggy/less-verbose-node-to-x-logging branch from 74c2b28 to 083fd89 Compare March 8, 2023 13:10
@newhoggy newhoggy enabled auto-merge March 8, 2023 13:11
@newhoggy newhoggy added this pull request to the merge queue Mar 8, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 8, 2023
@newhoggy newhoggy force-pushed the newhoggy/less-verbose-node-to-x-logging branch from 083fd89 to f9f20fa Compare March 8, 2023 22:41
@newhoggy newhoggy force-pushed the newhoggy/less-verbose-node-to-x-logging branch from f9f20fa to 61f94ff Compare March 10, 2023 00:17
@newhoggy newhoggy enabled auto-merge March 10, 2023 00:17
@newhoggy newhoggy added this pull request to the merge queue Mar 10, 2023
Merged via the queue into master with commit a51c64c Mar 10, 2023
@iohk-bors iohk-bors bot deleted the newhoggy/less-verbose-node-to-x-logging branch March 10, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@deepfire deepfire Awaiting requested review from deepfire

@jutaro jutaro Awaiting requested review from jutaro

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara

@coot coot Awaiting requested review from coot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Log only the most recent node-to-node & node-to-client protocol version
3 participants
@newhoggy @coot @Jimbo4350