CIP-1694 make space for DRep certificates #5108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newhoggy
commented
Apr 17, 2023
| -- | A resource that identifies the delegation target. At the moment a delegation | ||
| -- target can only be a stake pool. | ||
| newtype DelegationTarget | ||
| = StakePoolDelegationTarget (VerificationKeyOrHashOrFile StakePoolKey) |
There was a problem hiding this comment.
DelegationTarget is has one constructor StakePoolDelegationTarget which wraps VerificationKeyOrHashOrFile StakePoolKey.
Later on, another constructor will be added for DReps.
newhoggy
commented
Apr 17, 2023
| @@ -315,7 +315,7 @@ friendlyCertificate = | |||
| StakeAddressDeregistrationCertificate credential -> | |||
| "stake address deregistration" | |||
| .= object [friendlyStakeCredential credential] | |||
| StakeAddressDelegationCertificate credential poolId -> | |||
| StakeAddressPoolDelegationCertificate credential poolId -> | |||
There was a problem hiding this comment.
Rename StakeAddressDelegationCertificate to StakeAddressPoolDelegationCertificate so that we can introduce StakeAddressDRepDelegationCertificate later.
newhoggy
force-pushed
the
newhoggy/cip-1694-make-space-for-drep-certificates
branch
from
f950861
to
2d221ff
Compare
newhoggy
requested review from
dcoutts,
Jimbo4350,
erikd,
JaredCorduan and
CarlosLopezDeLara
as code owners
… identifying DReps for delegation
…nCertificate. This will make space for CIP-1926 which will introduce the StakeAddressDRepDelegationCertificate.
newhoggy
force-pushed
the
newhoggy/cip-1694-make-space-for-drep-certificates
branch
from
2d221ff
to
1232c20
Compare
erikd
approved these changes
Apr 17, 2023
carbolymer
approved these changes
Apr 17, 2023
iohk-bors
bot
deleted the
newhoggy/cip-1694-make-space-for-drep-certificates
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CIP-1694 introduces the idea of also delegating DReps in addition to stake pools.
The code currently use names that assume we can only delegate to stake pools from a stake-address.
This PR renames them to specifically refer to stake pools so that it is easier to add support for DReps later.