Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid bare IO in tests #5201

Merged
merged 2 commits into from
May 9, 2023
Merged

Avoid bare IO in tests #5201

merged 2 commits into from
May 9, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented May 7, 2023

Description

Avoid use of liftIO and use evalIO and hedgehog-extras versions of functions instead.

Using liftIO in hedgehog tests means that exceptions that are thrown are not ascribed to the correct file and line number in failure reports.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@newhoggy newhoggy changed the title Avoid bare io in tests Avoid bare IO in tests May 7, 2023
@newhoggy newhoggy marked this pull request as ready for review May 7, 2023 01:44
@newhoggy newhoggy requested a review from carbolymer May 7, 2023 02:00
@newhoggy newhoggy force-pushed the newhoggy/avoid-bare-io-in-tests branch from 973b589 to 0f7baf7 Compare May 8, 2023 01:09
@newhoggy newhoggy force-pushed the newhoggy/avoid-bare-io-in-tests branch from 0f7baf7 to f7cc5f8 Compare May 9, 2023 13:10
@newhoggy newhoggy force-pushed the newhoggy/avoid-bare-io-in-tests branch from f7cc5f8 to 506a32c Compare May 9, 2023 13:12
@newhoggy newhoggy enabled auto-merge May 9, 2023 13:59
@newhoggy newhoggy added this pull request to the merge queue May 9, 2023
Merged via the queue into master with commit 432238d May 9, 2023
@iohk-bors iohk-bors bot deleted the newhoggy/avoid-bare-io-in-tests branch May 9, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants