Remove all hardcoded yaml files from cardano-testnet #5242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
force-pushed
the
jordan/remove-hardcoded-yaml-files
branch
from
fe2e545
to
305bbc5
Compare
Jimbo4350
requested review from
dcoutts,
erikd,
newhoggy,
JaredCorduan and
CarlosLopezDeLara
as code owners
carbolymer
reviewed
May 15, 2023
| @@ -14,10 +14,12 @@ module Testnet.Babbage | |||
| , babbageTestnet | |||
| ) where | |||
|
|
|||
| import Cardano.Api | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
carbolymer
reviewed
May 15, 2023
| import Data.Word | ||
| import GHC.Stack | ||
| import Options.Applicative | ||
| import System.Directory (doesFileExist, removeFile) | ||
|
|
||
| import Cardano.Chain.Genesis (GenesisHash (unGenesisHash), readGenesisData) | ||
|
|
||
| import qualified Cardano.Crypto.Hash.Blake2b as Crypto |
There was a problem hiding this comment.
There was a problem hiding this comment.
There was a problem hiding this comment.
Made changes but opened a PR to suggest an update to the style doc.
carbolymer
approved these changes
May 15, 2023
|
This is good, but I think we should write the default yaml file to a golden file as well so the configuration file can easily be reviewed or read by non-coders. |
newhoggy
approved these changes
May 18, 2023
Jimbo4350
force-pushed
the
jordan/remove-hardcoded-yaml-files
branch
from
4cfad69
to
16d4130
Compare
Done 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hardcoding configuration files makes
cardano-testnetless portable and also introduces ambiguity into what your node configuration actually is.Checklist
See Runnings tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-8.10.7andghc-9.2.7Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.