Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --conway-era flag #5311

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Add --conway-era flag #5311

merged 1 commit into from
Jun 13, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Jun 9, 2023

Description

Add --conway-era flag.

There is still an unresolved error that will be resolved separately:

cardano-cli transaction build --conway-era --testnet-magic 42 --tx-in 'bf1e7a5edbd698b7b19f88a2761161247c31d0a0a989394f6e9ff51b450d72b2#0' --tx-out 'addr_test1vzvgd5ezqhwde7qjl428kkvaqnlfx3hvd27kcn4ahxc2zssc7d7he+300000000' --change-address addr_test1vqyug3rskwm2nur6zsdnwqznrs4gdqlp275pqqzrtuuxc0cmr6wc0 --out-file tx.raw

cardano-cli: Prelude.undefined
CallStack (from HasCallStack):
  error, called at libraries/base/GHC/Err.hs:79:14 in base:GHC.Err
  undefined, called at src/Cardano/Ledger/Conway/TxBody.hs:311:18 in crdn-ldgr-cnwy-1.2.0.0-d7c84ea9:Cardano.Ledger.Conway.TxBody

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@newhoggy newhoggy marked this pull request as ready for review June 9, 2023 13:10
@newhoggy newhoggy force-pushed the newhoggy/add-conway-era-flag branch from 3b463f1 to 28b9a76 Compare June 10, 2023 11:39
@newhoggy newhoggy force-pushed the newhoggy/add-conway-era-flag branch from 28b9a76 to 7dd3183 Compare June 13, 2023 00:30
@newhoggy newhoggy closed this Jun 13, 2023
@newhoggy newhoggy deleted the newhoggy/add-conway-era-flag branch June 13, 2023 00:33
@newhoggy newhoggy restored the newhoggy/add-conway-era-flag branch June 13, 2023 01:41
@newhoggy newhoggy reopened this Jun 13, 2023
@newhoggy newhoggy enabled auto-merge June 13, 2023 01:50
@newhoggy newhoggy added this pull request to the merge queue Jun 13, 2023
Merged via the queue into master with commit d9e7d7f Jun 13, 2023
50 of 52 checks passed
@iohk-bors iohk-bors bot deleted the newhoggy/add-conway-era-flag branch June 13, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants