Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links in docs #5427

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Fix broken links in docs #5427

merged 1 commit into from
Aug 4, 2023

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Aug 4, 2023

Description

This PR fixes broken docs links after #5422

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@carbolymer carbolymer force-pushed the mgalazyn/doc/fix-links branch 3 times, most recently from fe94c34 to 379f3be Compare August 4, 2023 15:26
@carbolymer carbolymer marked this pull request as ready for review August 4, 2023 15:31
@carbolymer carbolymer requested review from a team as code owners August 4, 2023 15:31
Copy link
Contributor

@NadiaYvette NadiaYvette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look like accurate documentation changes as I understand them.

@carbolymer carbolymer added this pull request to the merge queue Aug 4, 2023
Merged via the queue into master with commit 296de58 Aug 4, 2023
23 of 28 checks passed
@carbolymer carbolymer deleted the mgalazyn/doc/fix-links branch August 4, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants