Remove unused code in cardano-testnet #5491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbolymer
reviewed
Oct 3, 2023
| } | ||
|
|
||
| sbe <- case cardanoEraStyle era of | ||
| ShelleyBasedEra era' -> return era' |
There was a problem hiding this comment.
isn't that an incomplete pattern match?
carbolymer
approved these changes
Oct 3, 2023
Jimbo4350
force-pushed
the
jordan/remove-unused-code-cardano-testnet
branch
from
13ef1e8
to
363bb10
Compare
Jimbo4350
force-pushed
the
jordan/remove-unused-code-cardano-testnet
branch
from
363bb10
to
5b45309
Compare
Jimbo4350
force-pushed
the
jordan/remove-unused-code-cardano-testnet
branch
from
5b45309
to
8ed24b8
Compare
Use new functions from Testnet.Components.* to simplify the test Propagate changes due to cardanoTestnet now relying on the "create-staked" cli command
Propagate removal of BftTestnetNodeOptions Misc changes
Jimbo4350
force-pushed
the
jordan/remove-unused-code-cardano-testnet
branch
from
8ed24b8
to
57bd7a2
Compare
Jimbo4350
force-pushed
the
jordan/remove-unused-code-cardano-testnet
branch
from
57bd7a2
to
20f27f6
Compare
Icelandjack
pushed a commit
that referenced
this pull request
Oct 18, 2023
* Update hprop_kes_period_info to run in the Babbage era Use new functions from Testnet.Components.* to simplify the test Propagate changes due to cardanoTestnet now relying on the "create-staked" cli command * Add decodeEraUTxO Propagate removal of BftTestnetNodeOptions Misc changes * Remove Testnet.Commands.Shelley module * Remove Parsers.Shelley and Testnet.Start.Shelley modules * Remove Parsers.Babbage and Testnet.Start.Babbage modules * Remove: Testnet.Commands.Byron TestnetOptions StartConwayTestnet StartByrontestnet CardanoOnlyTestnetOptions * Remove: Parsers.Byron Parsers.Conway Testnet.Start.Conway ConwayTestnetOptions * Update cardano-testnet golden tests
NadiaYvette
pushed a commit
that referenced
this pull request
Nov 6, 2023
* Update hprop_kes_period_info to run in the Babbage era Use new functions from Testnet.Components.* to simplify the test Propagate changes due to cardanoTestnet now relying on the "create-staked" cli command * Add decodeEraUTxO Propagate removal of BftTestnetNodeOptions Misc changes * Remove Testnet.Commands.Shelley module * Remove Parsers.Shelley and Testnet.Start.Shelley modules * Remove Parsers.Babbage and Testnet.Start.Babbage modules * Remove: Testnet.Commands.Byron TestnetOptions StartConwayTestnet StartByrontestnet CardanoOnlyTestnetOptions * Remove: Parsers.Byron Parsers.Conway Testnet.Start.Conway ConwayTestnetOptions * Update cardano-testnet golden tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dead code removal
Also resolves: #4791
Checklist
See Runnings tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-8.10.7andghc-9.2.7Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.