fix: add offline check for networkWalidation in all enpdoints. Refact…

…or to tests so if any endpoint could work offline, a mock db is used (cardano-foundation#118)

src/server/index.ts

@@ -14,6 +14,7 @@ const { PORT, BIND_ADDRESS, DB_CONNECTION_STRING, LOGGER_ENABLED, LOGGER_LEVEL }
 // https://github.com/input-output-hk/cardano-rosetta/issues/101
 const genesis = JSON.parse(fs.readFileSync(path.resolve(process.env.GENESIS_PATH)).toString());
 const networkMagic = genesis.networkMagic;
+const networkId = genesis.networkId.toLowerCase();
 
 const configLogger = () =>
   pino({
@@ -30,7 +31,7 @@ const start = async (databaseInstance: Pool) => {
     // FIXME: validate the following paraemeters when implementing (2)
     // https://github.com/input-output-hk/cardano-rosetta/issues/101
     const cardanoCli = CardanoCli.configure(process.env.CARDANOCLI_PATH, networkMagic, logger);
-    const services = Services.configure(repository, cardanoCli, logger);
+    const services = Services.configure(repository, cardanoCli, logger, networkId);
     server = buildServer(services, LOGGER_ENABLED === 'true');
     server.addHook('onClose', (fastify, done) => databaseInstance.end(done));
     // eslint-disable-next-line no-magic-numbers

src/server/services/account-service.ts

@@ -24,12 +24,12 @@ const parseUtxoDetails = (utxoDetails: Utxo[], logger: Logger): Components.Schem
 const configure = (
   networkRepository: NetworkRepository,
   blockService: BlockService,
-  logger: Logger
+  logger: Logger,
+  networkId: string
 ): AccountService => ({
   accountBalance: async accountBalanceRequest =>
     withNetworkValidation(
       accountBalanceRequest.network_identifier,
-      networkRepository,
       accountBalanceRequest,
       async () => {
         logger.debug({ accountBalanceRequest }, '[accountBalance] Request received');
@@ -67,7 +67,8 @@ const configure = (
           coins: parseUtxoDetails(utxoDetails, logger)
         };
       },
-      logger
+      logger,
+      networkId
     )
 });
 

src/server/services/block-service.ts

@@ -151,7 +151,8 @@ const configure = (
   repository: BlockchainRepository,
   PAGE_SIZE: number,
   networkRepository: NetworkRepository,
-  logger: Logger
+  logger: Logger,
+  networkId: string
 ): BlockService => ({
   async findBlock(blockIdentifier) {
     logger.info({ blockIdentifier }, '[findBlock] Looking for block:');
@@ -238,7 +239,6 @@ const configure = (
   blockTransaction: async blockTransactionRequest =>
     withNetworkValidation(
       blockTransactionRequest.network_identifier,
-      networkRepository,
       blockTransactionRequest,
       async () => {
         const transactionHash = blockTransactionRequest.transaction_identifier.hash;
@@ -259,7 +259,8 @@ const configure = (
           transaction: response
         };
       },
-      logger
+      logger,
+      networkId
     )
 });
 

src/server/services/construction-service.ts

@@ -59,15 +59,14 @@ const constructPayloadsForTransactionBody = (
 
 const configure = (
   cardanoService: CardanoService,
-  networkRepository: NetworkRepository,
   blockService: BlockService,
   cardanoCli: CardanoCli,
-  logger: Logger
+  logger: Logger,
+  networkId: string
 ): ConstructionService => ({
   constructionDerive: async request =>
     withNetworkValidation(
       request.network_identifier,
-      networkRepository,
       request,
       async () => {
         const publicKey = request.public_key;
@@ -81,12 +80,12 @@ const configure = (
           address
         };
       },
-      logger
+      logger,
+      networkId
     ),
   constructionHash: async request =>
     withNetworkValidation(
       request.network_identifier,
-      networkRepository,
       request,
       async () => {
         const signedTransaction = request.signed_transaction;
@@ -96,35 +95,35 @@ const configure = (
         // eslint-disable-next-line camelcase
         return { transaction_identifier: { hash: transactionHash } };
       },
-      logger
+      logger,
+      networkId
     ),
   constructionPreprocess: async request =>
     withNetworkValidation(
       request.network_identifier,
-      networkRepository,
       request,
       async () =>
         // eslint-disable-next-line camelcase
         ({ options: { relative_ttl: request.metadata.relative_ttl } }),
-      logger
+      logger,
+      networkId
     ),
   constructionMetadata: async request =>
     withNetworkValidation(
       request.network_identifier,
-      networkRepository,
       request,
       async () => {
         const ttlOffset = request.options.relative_ttl;
         const latestBlock = await blockService.getLatestBlock();
         const ttl = (BigInt(latestBlock.slotNo) + BigInt(ttlOffset)).toString();
         return { metadata: { ttl } };
       },
-      logger
+      logger,
+      networkId
     ),
   constructionPayloads: async request =>
     withNetworkValidation(
       request.network_identifier,
-      networkRepository,
       request,
       async () => {
         const ttl = request.metadata.ttl;
@@ -134,12 +133,12 @@ const configure = (
         // eslint-disable-next-line camelcase
         return { unsigned_transaction: unsignedTransaction.bytes, payloads };
       },
-      logger
+      logger,
+      networkId
     ),
   constructionCombine: async request =>
     withNetworkValidation(
       request.network_identifier,
-      networkRepository,
       request,
       async () => {
         logger.info('[constructionCombine] Request received to sign a transaction');
@@ -154,12 +153,12 @@ const configure = (
         // eslint-disable-next-line camelcase
         return { signed_transaction: signedTransaction };
       },
-      logger
+      logger,
+      networkId
     ),
   constructionParse: async request =>
     withNetworkValidation(
       request.network_identifier,
-      networkRepository,
       request,
       async () => {
         const signed = request.signed;
@@ -176,12 +175,12 @@ const configure = (
           ...cardanoService.parseUnsignedTransaction(request.transaction)
         };
       },
-      logger
+      logger,
+      networkId
     ),
   constructionSubmit: async request =>
     withNetworkValidation(
       request.network_identifier,
-      networkRepository,
       request,
       async () => {
         try {
@@ -197,7 +196,8 @@ const configure = (
           return ErrorFactory.sendTransactionError(error.message);
         }
       },
-      logger
+      logger,
+      networkId
     )
 });
 

src/server/services/network-service.ts

@@ -51,7 +51,8 @@ const configure = (
   networkRepository: NetworkRepository,
   blockchainService: BlockService,
   topologyFile: TopologyConfig,
-  logger: Logger
+  logger: Logger,
+  networkId: string
 ): NetworkService => ({
   async networkList() {
     logger.info('[networkList] Looking for all supported networks');
@@ -73,7 +74,6 @@ const configure = (
   networkStatus: async networkStatusRequest =>
     withNetworkValidation(
       networkStatusRequest.network_identifier,
-      networkRepository,
       networkStatusRequest,
       async () => {
         logger.debug({ networkStatusRequest }, '[networkStatus] Request received:');
@@ -101,12 +101,12 @@ const configure = (
         logger.debug({ response }, '[networkStatus] Returning response:');
         return response;
       },
-      logger
+      logger,
+      networkId
     ),
   networkOptions: async networkOptionsRequest =>
     withNetworkValidation(
       networkOptionsRequest.network_identifier,
-      networkRepository,
       networkOptionsRequest,
       async () => {
         logger.info('[networkOptions] Looking for networkOptions');
@@ -132,7 +132,8 @@ const configure = (
         logger.debug({ response }, '[networkOptions] Returning response:');
         return response;
       },
-      logger
+      logger,
+      networkId
     )
 });
 

src/server/services/services.ts

@@ -42,25 +42,25 @@ const loadPageSize = (logger: Logger): number => {
  *
  * @param repositories repositories to be used by the services
  */
-export const configure = (repositories: Repositories, cardanoCli: CardanoCli, logger: Logger): Services => {
+export const configure = (
+  repositories: Repositories,
+  cardanoCli: CardanoCli,
+  logger: Logger,
+  networkId: string
+): Services => {
   const blockServiceInstance = blockService(
     repositories.blockchainRepository,
     loadPageSize(logger),
     repositories.networkRepository,
-    logger
+    logger,
+    networkId
   );
   const cardanoServiceInstance = cardanoService(logger);
   return {
-    ...accountService(repositories.networkRepository, blockServiceInstance, logger),
+    ...accountService(repositories.networkRepository, blockServiceInstance, logger, networkId),
     ...blockServiceInstance,
-    ...constructionService(
-      cardanoServiceInstance,
-      repositories.networkRepository,
-      blockServiceInstance,
-      cardanoCli,
-      logger
-    ),
-    ...networkService(repositories.networkRepository, blockServiceInstance, loadTopologyFile(), logger),
+    ...constructionService(cardanoServiceInstance, blockServiceInstance, cardanoCli, logger, networkId),
+    ...networkService(repositories.networkRepository, blockServiceInstance, loadTopologyFile(), logger, networkId),
     ...cardanoServiceInstance
   };
 };

src/server/services/utils/services-helper.ts

@@ -1,14 +1,13 @@
-import { NetworkRepository } from '../../db/network-repository';
 import { CARDANO } from '../../utils/constants';
 import { ErrorFactory } from '../../utils/errors';
 import { Logger } from 'fastify';
 
 export const withNetworkValidation = async <T, R>(
   networkIdentifier: Components.Schemas.NetworkIdentifier,
-  repository: NetworkRepository,
   parameters: T,
   nextFn: (param: T) => R,
-  logger: Logger
+  logger: Logger,
+  networkId: string
 ): Promise<R> => {
   logger.debug('[withNetworkValidation] About to validate requests network identifier parameter', networkIdentifier);
   const blockchain: string = networkIdentifier.blockchain;
@@ -19,7 +18,7 @@ export const withNetworkValidation = async <T, R>(
     throw ErrorFactory.invalidBlockchainError();
   }
 
-  const networkExists = await repository.networkExists(network);
+  const networkExists = networkId === network;
   if (!networkExists) {
     logger.error('[withNetworkValidation] Network parameter is not supported: ', network);
     throw ErrorFactory.networkNotFoundError();

test/e2e/account-api.test.ts

@@ -59,7 +59,7 @@ describe('/account/balance endpoint', () => {
   let database: Pool;
   let server: FastifyInstance;
   beforeAll(async () => {
-    database = setupDatabase();
+    database = setupDatabase(false);
     server = setupServer(database);
   });
 

test/e2e/block-api.test.ts

@@ -33,7 +33,7 @@ describe('Block API', () => {
   let database: Pool;
   let server: FastifyInstance;
   beforeAll(async () => {
-    database = setupDatabase();
+    database = setupDatabase(false);
     server = setupServer(database);
   });
 

test/e2e/construction-api.test.ts

@@ -63,7 +63,7 @@ describe('Construction API', () => {
   let database: Pool;
   let server: FastifyInstance;
   beforeAll(async () => {
-    database = setupDatabase();
+    database = setupDatabase(true);
     server = setupServer(database);
   });
 
@@ -219,6 +219,11 @@ describe('Construction API', () => {
   });
 
   describe(CONSTRUCTION_METADATA_ENDPOINT, () => {
+    beforeAll(async () => {
+      database = setupDatabase(false);
+      server = setupServer(database);
+    });
+
     test('Should return a valid TTL when the parameters are valid', async () => {
       const response = await server.inject({
         method: 'post',
@@ -234,6 +239,7 @@ describe('Construction API', () => {
       (blockchain, network) => generateMetadataPayload(blockchain, network, 100),
       () => server
     );
+
   });
 
   describe(CONSTRUCTION_COMBINE_ENDPOINT, () => {

test/e2e/network-api.test.ts

@@ -127,7 +127,7 @@ describe('/network/list endpoint', () => {
   let database: Pool;
   let server: FastifyInstance;
   beforeAll(async () => {
-    database = setupDatabase();
+    database = setupDatabase(false);
     server = setupServer(database);
   });
 
@@ -151,7 +151,7 @@ describe('/network/options endpoint', () => {
   let database: Pool;
   let server: FastifyInstance;
   beforeAll(async () => {
-    database = setupDatabase();
+    database = setupDatabase(false);
     server = setupServer(database);
   });
 
@@ -209,7 +209,7 @@ describe('/network/status endpoint', () => {
   let database: Pool;
   let server: FastifyInstance;
   beforeAll(async () => {
-    database = setupDatabase();
+    database = setupDatabase(false);
     server = setupServer(database);
   });