fix: add missing error codes to network options test

input-output-hk · Jan 21, 2021 · e65d40f · e65d40f
1 parent 172454b
commit e65d40f
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 5 deletions.
diff --git a/cardano-rosetta-server/src/server/controllers/network-controller.ts b/cardano-rosetta-server/src/server/controllers/network-controller.ts
@@ -1,10 +1,10 @@
 import { FastifyRequest } from 'fastify';
 import { NetworkService } from '../services/network-service';
+import { CardanoNode } from '../utils/cardano/cli/cardano-node';
 import { MIDDLEWARE_VERSION, OPERATION_TYPES, ROSETTA_VERSION, SUCCESS_OPERATION_STATE } from '../utils/constants';
 import { mapToNetworkList, mapToNetworkStatusResponse } from '../utils/data-mapper';
 import { ErrorFactory } from '../utils/errors';
 import { withNetworkValidation } from './controllers-helper';
-import { CardanoNode } from '../utils/cardano/cli/cardano-node';
 
 /* eslint-disable camelcase */
 export interface NetworkController {

diff --git a/cardano-rosetta-server/src/server/utils/errors.ts b/cardano-rosetta-server/src/server/utils/errors.ts
@@ -128,7 +128,7 @@ const invalidOperationTypeError: CreateErrorFunction = type => buildApiError(Err
 const tokenBundleAssetsMissingError: CreateErrorFunction = type =>
   buildApiError(Errors.TOKEN_BUNDLE_ASSETS_MISSING, false, type);
 const tokenAssetValueMissingError: CreateErrorFunction = type =>
-  buildApiError(Errors.TOKEN_BUNDLE_ASSETS_MISSING, false, type);
+  buildApiError(Errors.TOKEN_ASSET_VALUE_MISSING, false, type);
 
 export const ErrorFactory = {
   blockNotFoundError,

diff --git a/cardano-rosetta-server/test/e2e/network/network-options-api.test.ts b/cardano-rosetta-server/test/e2e/network/network-options-api.test.ts
@@ -1,11 +1,11 @@
 /* eslint-disable camelcase */
-import { Pool } from 'pg';
 import { FastifyInstance } from 'fastify';
 import StatusCodes from 'http-status-codes';
-import { setupDatabase, setupServer, testInvalidNetworkParameters } from '../utils/test-utils';
+import { Pool } from 'pg';
+import packageJson from '../../../package.json';
 import { CARDANO, MAINNET, OPERATION_TYPES } from '../../../src/server/utils/constants';
+import { setupDatabase, setupServer, testInvalidNetworkParameters } from '../utils/test-utils';
 import { generateNetworkPayload } from './common';
-import packageJson from '../../../package.json';
 
 const NETWORK_OPTIONS_ENDPOINT = '/network/options';
 
@@ -94,6 +94,16 @@ const allow = {
       message: 'Pool key hash is required for stake delegation',
       retriable: false
     },
+    {
+      code: 4021,
+      message: 'Assets are required for output operation token bundle',
+      retriable: false
+    },
+    {
+      code: 4022,
+      message: 'Asset value is required for token asset',
+      retriable: false
+    },
     {
       code: 5000,
       message: 'An error occurred',